From 689c66a84bb75e08462c05ffc18514895b19d48e Mon Sep 17 00:00:00 2001 From: Peter Eisentraut Date: Tue, 29 Aug 2023 08:52:22 +0200 Subject: [PATCH] Remove useless if condition This is useless because these fields are not set anywhere before, so we can assign them unconditionally. This also makes this more consistent with ATExecAddColumn(). Reviewed-by: Alvaro Herrera Discussion: https://www.postgresql.org/message-id/flat/52a125e4-ff9a-95f5-9f61-b87cf447e4da@eisentraut.org --- src/backend/commands/tablecmds.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/src/backend/commands/tablecmds.c b/src/backend/commands/tablecmds.c index a8c40ace10..48f17a3403 100644 --- a/src/backend/commands/tablecmds.c +++ b/src/backend/commands/tablecmds.c @@ -942,11 +942,8 @@ DefineRelation(CreateStmt *stmt, char relkind, Oid ownerId, attr->atthasdef = true; } - if (colDef->identity) - attr->attidentity = colDef->identity; - - if (colDef->generated) - attr->attgenerated = colDef->generated; + attr->attidentity = colDef->identity; + attr->attgenerated = colDef->generated; if (colDef->compression) attr->attcompression = GetAttributeCompression(attr->atttypid,