mirrors/postgres
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix session-lifespan memory leak when a plperl function is redefined:

Browse Source 
we have to tell Perl it can release its compiled copy of the function
text.  Noted by Alexey Klyukin.

Back-patch to 8.2 --- the problem exists further back, but this patch
won't work without modification, and it's probably not worth the trouble.
This commit is contained in:
Tom Lane 2009-11-29 21:02:16 +00:00
parent 22032820f9
commit 67ec9adaf1
1 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/pl/plperl/plperl.c
View File

@ -1,7 +1,7 @@
/********************************************************************** /**********************************************************************
* plperl.c - perl as a procedural language for PostgreSQL * plperl.c - perl as a procedural language for PostgreSQL
* *
* $PostgreSQL: pgsql/src/pl/plperl/plperl.c,v 1.154 2009/11/29 03:02:27 tgl Exp $ * $PostgreSQL: pgsql/src/pl/plperl/plperl.c,v 1.155 2009/11/29 21:02:16 tgl Exp $
* *
**********************************************************************/ **********************************************************************/
@ -1651,11 +1651,13 @@ compile_plperl_function(Oid fn_oid, bool is_trigger)
if (!uptodate) if (!uptodate)
{ {
hash_search(plperl_proc_hash, internal_proname,
HASH_REMOVE, NULL);
if (prodesc->reference)
SvREFCNT_dec(prodesc->reference);
free(prodesc->proname); free(prodesc->proname);
free(prodesc); free(prodesc);
prodesc = NULL; prodesc = NULL;
hash_search(plperl_proc_hash, internal_proname,
HASH_REMOVE, NULL);
} }
} }