mirrors/postgres
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Avoid time-of-day-dependent failure in log rotation test.

Browse Source 
Buildfarm members pogona and petalura have shown a failure when
pg_ctl/t/004_logrotate.pl starts just before local midnight.
The default rotate-at-midnight behavior occurs just before the
Perl script examines current_logfiles, so it figures that the
rotation it's already requested has occurred ... but in reality,
that rotation happens just after it looks, so the expected new
log data goes into a different file than the one it's examining.

In HEAD, src/test/kerberos/t/001_auth.pl has acquired similar code
that evidently has a related failure mode.  Besides being quite new,
few buildfarm critters run that test, so it's unsurprising that
we've not yet seen a failure there.

Fix both cases by setting log_rotation_age = 0 so that no time-based
rotation can occur.  Also absorb 004_logrotate.pl's decision to
set lc_messages = 'C' into the kerberos test, in hopes that it will
work in non-English prevailing locales.

Report: https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=pogona&dt=2020-12-24%2022%3A10%3A04
Report: https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=petalura&dt=2020-02-01%2022%3A20%3A04
This commit is contained in:
Tom Lane 2020-12-24 21:37:46 -05:00
parent 558a6e8e21
commit 5c31afc49d
2 changed files with 12 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/bin/pg_ctl/t/004_logrotate.pl
View File

@ -12,6 +12,8 @@ $node->init();
$node->append_conf( $node->append_conf(
'postgresql.conf', qq( 'postgresql.conf', qq(
logging_collector = on logging_collector = on
# these ensure stability of test results:
log_rotation_age = 0
lc_messages = 'C' lc_messages = 'C'
)); ));

14
src/test/kerberos/t/001_auth.pl
View File

@ -163,10 +163,16 @@ note "setting up PostgreSQL instance";
my $node = get_new_node('node'); my $node = get_new_node('node');
$node->init; $node->init;
$node->append_conf('postgresql.conf', "listen_addresses = '$hostaddr'"); $node->append_conf(
$node->append_conf('postgresql.conf', "krb_server_keyfile = '$keytab'"); 'postgresql.conf', qq{
$node->append_conf('postgresql.conf', "logging_collector = on"); listen_addresses = '$hostaddr'
$node->append_conf('postgresql.conf', "log_connections = on"); krb_server_keyfile = '$keytab'
logging_collector = on
log_connections = on
# these ensure stability of test results:
log_rotation_age = 0
lc_messages = 'C'
});
$node->start; $node->start;
$node->safe_psql('postgres', 'CREATE USER test1;'); $node->safe_psql('postgres', 'CREATE USER test1;');