mirrors
/
postgres
mirror of https://github.com/postgres/postgres
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix one-byte buffer overrun in PQprintTuples(). 

This bug goes back to the original Postgres95 sources.  Its significance
to modern PG versions is marginal, since we have not used PQprintTuples()
internally in a very long time, and it doesn't seem to have ever been
documented either.  Still, it *is* exposed to client apps, so somebody
out there might possibly be using it.

Xi Wang
This commit is contained in:
Tom Lane 2013-01-20 23:44:11 -05:00
parent 237dc2d783
commit 59d70a5e9c
1 changed files with 3 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/interfaces/libpq/fe-print.c
View File

@ -686,7 +686,6 @@ PQprintTuples(const PGresult *res,
int i,
j;
char formatString[80];
char *tborder = NULL;
nFields = PQnfields(res);
@ -705,15 +704,15 @@ PQprintTuples(const PGresult *res,
int width;
width = nFields * 14;
tborder = malloc(width + 1);
tborder = (char *) malloc(width + 1);
if (!tborder)
{
fprintf(stderr, libpq_gettext("out of memory\n"));
exit(1);
}
for (i = 0; i <= width; i++)
for (i = 0; i < width; i++)
tborder[i] = '-';
tborder[i] = '\0';
tborder[width] = '\0';
fprintf(fout, "%s\n", tborder);
}