mirrors/postgres
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Remove bogus set_ps_display call --- changing displayed status here is

Browse Source 
either wrong or unnecessary in most cases, and on systems where setting
status takes a kernel call, the overhead of setting status three times
per command rather than two is annoying.
This commit is contained in:
Tom Lane 2001-02-18 04:28:31 +00:00
parent 81ff09eeb5
commit 58c4ab9d62
1 changed files with 8 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
src/backend/tcop/postgres.c
View File

@ -8,7 +8,7 @@
* *
* *
* IDENTIFICATION * IDENTIFICATION
* $Header: /cvsroot/pgsql/src/backend/tcop/postgres.c,v 1.206 2001/01/24 19:43:09 momjian Exp $ * $Header: /cvsroot/pgsql/src/backend/tcop/postgres.c,v 1.207 2001/02/18 04:28:31 tgl Exp $
* *
* NOTES * NOTES
* this is the "main" module of the postgres backend and * this is the "main" module of the postgres backend and
@ -878,7 +878,7 @@ finish_xact_command(void)
/* Now commit the command */ /* Now commit the command */
if (DebugLvl >= 1) if (DebugLvl >= 1)
elog(DEBUG, "CommitTransactionCommand"); elog(DEBUG, "CommitTransactionCommand");
set_ps_display("commit"); /* XXX probably the wrong place to do this */
CommitTransactionCommand(); CommitTransactionCommand();
#ifdef SHOW_MEMORY_STATS #ifdef SHOW_MEMORY_STATS
@ -1680,7 +1680,7 @@ PostgresMain(int argc, char *argv[], int real_argc, char *real_argv[], const cha
if (!IsUnderPostmaster) if (!IsUnderPostmaster)
{ {
puts("\nPOSTGRES backend interactive interface "); puts("\nPOSTGRES backend interactive interface ");
puts("$Revision: 1.206 $ $Date: 2001/01/24 19:43:09 $\n"); puts("$Revision: 1.207 $ $Date: 2001/02/18 04:28:31 $\n");
} }
/* /*
@ -1781,6 +1781,11 @@ PostgresMain(int argc, char *argv[], int real_argc, char *real_argv[], const cha
*/ */
ReadyForQuery(whereToSendOutput); ReadyForQuery(whereToSendOutput);
if (IsTransactionBlock())
set_ps_display("idle in transaction");
else
set_ps_display("idle");
/* ---------------- /* ----------------
* (2) deal with pending asynchronous NOTIFY from other backends, * (2) deal with pending asynchronous NOTIFY from other backends,
* and enable async.c's signal handler to execute NOTIFY directly. * and enable async.c's signal handler to execute NOTIFY directly.
@ -1791,10 +1796,6 @@ PostgresMain(int argc, char *argv[], int real_argc, char *real_argv[], const cha
EnableNotifyInterrupt(); EnableNotifyInterrupt();
if (!IsTransactionBlock())
set_ps_display("idle");
else set_ps_display("idle in transaction");
/* Allow "die" interrupt to be processed while waiting */ /* Allow "die" interrupt to be processed while waiting */
ImmediateInterruptOK = true; ImmediateInterruptOK = true;
/* and don't forget to detect one that already arrived */ /* and don't forget to detect one that already arrived */