mirrors/postgres
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Provide better message when CREATE EXTENSION can't find a target schema.

Browse Source 
The new message (and SQLSTATE) matches the corresponding error cases in
namespace.c.

This was thought to be a "can't happen" case when extension.c was written,
so we didn't think hard about how to report it.  But it definitely can
happen in 9.2 and later, since we no longer require search_path to contain
any valid schema names.  It's probably also possible in 9.1 if search_path
came from a noninteractive source.  So, back-patch to all releases
containing this code.

Per report from Sean Chittenden, though this isn't exactly his patch.
This commit is contained in:
Tom Lane 2013-06-04 17:22:29 -04:00
parent 5c7603c318
commit 530acda4da
1 changed files with 7 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/backend/commands/extension.c
View File

@ -1394,12 +1394,16 @@ CreateExtension(CreateExtensionStmt *stmt)
*/ */
List *search_path = fetch_search_path(false); List *search_path = fetch_search_path(false);
if (search_path == NIL) /* probably can't happen */ if (search_path == NIL) /* nothing valid in search_path? */
elog(ERROR, "there is no default creation target"); ereport(ERROR,
(errcode(ERRCODE_UNDEFINED_SCHEMA),
errmsg("no schema has been selected to create in")));
schemaOid = linitial_oid(search_path); schemaOid = linitial_oid(search_path);
schemaName = get_namespace_name(schemaOid); schemaName = get_namespace_name(schemaOid);
if (schemaName == NULL) /* recently-deleted namespace? */ if (schemaName == NULL) /* recently-deleted namespace? */
elog(ERROR, "there is no default creation target"); ereport(ERROR,
(errcode(ERRCODE_UNDEFINED_SCHEMA),
errmsg("no schema has been selected to create in")));
list_free(search_path); list_free(search_path);
} }