diff --git a/doc/src/sgml/charset.sgml b/doc/src/sgml/charset.sgml
index 48ecfc5f48..f2a4acc115 100644
--- a/doc/src/sgml/charset.sgml
+++ b/doc/src/sgml/charset.sgml
@@ -653,9 +653,8 @@ SELECT a COLLATE "C" < b COLLATE "POSIX" FROM test1;
string will be accepted as a locale name.)
See for
information on ICU locale naming. initdb uses the ICU
- APIs to extract a set of locales with distinct collation rules to populate
- the initial set of collations. Here are some example collations that
- might be created:
+ APIs to extract a set of distinct locales to populate the initial set of
+ collations. Here are some example collations that might be created:
@@ -677,9 +676,9 @@ SELECT a COLLATE "C" < b COLLATE "POSIX" FROM test1;
German collation for Austria, default variant
- (As of this writing, there is no,
- say, de-DE-x-icu or de-CH-x-icu,
- because those are equivalent to de-x-icu.)
+ (There are also, say, de-DE-x-icu
+ or de-CH-x-icu, but as of this writing, they are
+ equivalent to de-x-icu.)
@@ -690,6 +689,7 @@ SELECT a COLLATE "C" < b COLLATE "POSIX" FROM test1;
German collation for Austria, phone book variant
+
und-x-icu (for undefined
)
@@ -724,7 +724,6 @@ SELECT a COLLATE "C" < b COLLATE "POSIX" FROM test1;
CREATE COLLATION german FROM "de_DE";
CREATE COLLATION french FROM "fr-x-icu";
-CREATE COLLATION "de-DE-x-icu" FROM "de-x-icu";
diff --git a/src/backend/commands/collationcmds.c b/src/backend/commands/collationcmds.c
index 8572b2dedc..d36ce53560 100644
--- a/src/backend/commands/collationcmds.c
+++ b/src/backend/commands/collationcmds.c
@@ -667,7 +667,16 @@ pg_import_system_collations(PG_FUNCTION_ARGS)
}
#endif /* READ_LOCALE_A_OUTPUT */
- /* Load collations known to ICU */
+ /*
+ * Load collations known to ICU
+ *
+ * We use uloc_countAvailable()/uloc_getAvailable() rather than
+ * ucol_countAvailable()/ucol_getAvailable(). The former returns a full
+ * set of language+region combinations, whereas the latter only returns
+ * language+region combinations of they are distinct from the language's
+ * base collation. So there might not be a de-DE or en-GB, which would be
+ * confusing.
+ */
#ifdef USE_ICU
{
int i;
@@ -676,7 +685,7 @@ pg_import_system_collations(PG_FUNCTION_ARGS)
* Start the loop at -1 to sneak in the root locale without too much
* code duplication.
*/
- for (i = -1; i < ucol_countAvailable(); i++)
+ for (i = -1; i < uloc_countAvailable(); i++)
{
/*
* In ICU 4.2, ucol_getKeywordValuesForLocale() sometimes returns
@@ -706,7 +715,7 @@ pg_import_system_collations(PG_FUNCTION_ARGS)
if (i == -1)
name = ""; /* ICU root locale */
else
- name = ucol_getAvailable(i);
+ name = uloc_getAvailable(i);
langtag = get_icu_language_tag(name);
collcollate = U_ICU_VERSION_MAJOR_NUM >= 54 ? langtag : name;