mirrors/postgres
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Prohibit altering invalidated replication slots.

Browse Source 
ALTER_REPLICATION_SLOT for invalid replication slots should not be allowed
because there is no way to get back the invalidated (logical) slot to
work.

Author: Bharath Rupireddy
Reviewed-by: Peter Smith, Shveta Malik
Discussion: https://www.postgresql.org/message-id/CALj2ACW4fSOMiKjQ3=2NVBMTZRTG8Ujg6jsK9z3EvOtvA4vzKQ@mail.gmail.com
This commit is contained in:
Amit Kapila 2024-09-13 09:29:13 +05:30
parent 7b1ddbae36
commit 4d8489f4f1
2 changed files with 18 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/backend/replication/slot.c
View File

@ -820,6 +820,13 @@ ReplicationSlotAlter(const char *name, const bool *failover,
errmsg("cannot use %s with a physical replication slot", errmsg("cannot use %s with a physical replication slot",
"ALTER_REPLICATION_SLOT")); "ALTER_REPLICATION_SLOT"));
if (MyReplicationSlot->data.invalidated != RS_INVAL_NONE)
ereport(ERROR,
errcode(ERRCODE_OBJECT_NOT_IN_PREREQUISITE_STATE),
errmsg("cannot alter invalid replication slot \"%s\"", name),
errdetail("This replication slot has been invalidated due to \"%s\".",
SlotInvalidationCauses[MyReplicationSlot->data.invalidated]));
if (RecoveryInProgress()) if (RecoveryInProgress())
{ {
/* /*

12
src/test/recovery/t/035_standby_logical_decoding.pl
View File

@ -495,7 +495,8 @@ $node_subscriber->stop;
# Scenario 1: hot_standby_feedback off and vacuum FULL # Scenario 1: hot_standby_feedback off and vacuum FULL
# #
# In passing, ensure that replication slot stats are not removed when the # In passing, ensure that replication slot stats are not removed when the
# active slot is invalidated. # active slot is invalidated, and check that an error occurs when
# attempting to alter the invalid slot.
################################################## ##################################################
# One way to produce recovery conflict is to create/drop a relation and # One way to produce recovery conflict is to create/drop a relation and
@ -526,6 +527,15 @@ check_for_invalidation('vacuum_full_', 1, 'with vacuum FULL on pg_class');
# Verify reason for conflict is 'rows_removed' in pg_replication_slots # Verify reason for conflict is 'rows_removed' in pg_replication_slots
check_slots_conflict_reason('vacuum_full_', 'rows_removed'); check_slots_conflict_reason('vacuum_full_', 'rows_removed');
# Attempting to alter an invalidated slot should result in an error
($result, $stdout, $stderr) = $node_standby->psql(
'postgres',
qq[ALTER_REPLICATION_SLOT vacuum_full_inactiveslot (failover);],
replication => 'database');
ok($stderr =~ /ERROR: cannot alter invalid replication slot "vacuum_full_inactiveslot"/ &&
$stderr =~ /DETAIL: This replication slot has been invalidated due to "rows_removed"./,
"invalidated slot cannot be altered");
# Ensure that replication slot stats are not removed after invalidation. # Ensure that replication slot stats are not removed after invalidation.
is( $node_standby->safe_psql( is( $node_standby->safe_psql(
'testdb', 'testdb',