mirrors/postgres
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

equal() needs a case for Aggref nodes, as shown by:

Browse Source 
regression=> select sum(q1) from int8_tbl group by q2 order by sum(q1);
NOTICE:  equal: don't know whether nodes of type 107 are equal
This commit is contained in:
Tom Lane 1999-06-06 17:46:40 +00:00
parent dfaf9fbcb4
commit 48c1887964
1 changed files with 25 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
src/backend/nodes/equalfuncs.c
View File

@ -7,7 +7,7 @@
* *
* *
* IDENTIFICATION * IDENTIFICATION
* $Header: /cvsroot/pgsql/src/backend/nodes/equalfuncs.c,v 1.38 1999/05/25 22:41:13 momjian Exp $ * $Header: /cvsroot/pgsql/src/backend/nodes/equalfuncs.c,v 1.39 1999/06/06 17:46:40 tgl Exp $
* *
*------------------------------------------------------------------------- *-------------------------------------------------------------------------
*/ */
@ -257,6 +257,27 @@ _equalParam(Param *a, Param *b)
return true; return true;
} }
/*
* Aggref is a subclass of Expr.
*/
static bool
_equalAggref(Aggref *a, Aggref *b)
{
if (strcmp(a->aggname, b->aggname) != 0)
return false;
if (a->basetype != b->basetype)
return false;
if (a->aggtype != b->aggtype)
return false;
if (!equal(a->target, b->target))
return false;
if (a->aggno != b->aggno)
return false;
if (a->usenulls != b->usenulls)
return false;
return true;
}
/* /*
* Func is a subclass of Expr. * Func is a subclass of Expr.
*/ */
@ -769,6 +790,9 @@ equal(void *a, void *b)
case T_Param: case T_Param:
retval = _equalParam(a, b); retval = _equalParam(a, b);
break; break;
case T_Aggref:
retval = _equalAggref(a, b);
break;
case T_Func: case T_Func:
retval = _equalFunc(a, b); retval = _equalFunc(a, b);
break; break;