mirrors/postgres
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Revert "Prevent instability in contrib/pageinspect's regression test."

Browse Source 
This reverts commit 5cda142bb9d2bd7e7ed1c22ae89afe58abfa8d7b
(in v14 only).

It turns out that that fails under force_parallel_mode = regress,
because pageinspect's disk-access functions are marked parallel
safe, which they are not if you try to use them on a temp table.
The cost of fixing that pre-v15 seems to exceed the value of
making this test case fully stable, so we will just leave things
as-is in v14.
This commit is contained in:
Tom Lane 2022-11-21 15:37:48 -05:00
parent 5cda142bb9
commit 47a22dc2cb
2 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
contrib/pageinspect/expected/page.out
View File

@ -1,6 +1,5 @@
CREATE EXTENSION pageinspect; CREATE EXTENSION pageinspect;
-- Use a temp table so that effects of VACUUM are predictable CREATE TABLE test1 (a int, b int);
CREATE TEMP TABLE test1 (a int, b int);
INSERT INTO test1 VALUES (16777217, 131584); INSERT INTO test1 VALUES (16777217, 131584);
VACUUM (DISABLE_PAGE_SKIPPING) test1; -- set up FSM VACUUM (DISABLE_PAGE_SKIPPING) test1; -- set up FSM
-- The page contents can vary, so just test that it can be read -- The page contents can vary, so just test that it can be read

3
contrib/pageinspect/sql/page.sql
View File

@ -1,7 +1,6 @@
CREATE EXTENSION pageinspect; CREATE EXTENSION pageinspect;
-- Use a temp table so that effects of VACUUM are predictable CREATE TABLE test1 (a int, b int);
CREATE TEMP TABLE test1 (a int, b int);
INSERT INTO test1 VALUES (16777217, 131584); INSERT INTO test1 VALUES (16777217, 131584);
VACUUM (DISABLE_PAGE_SKIPPING) test1; -- set up FSM VACUUM (DISABLE_PAGE_SKIPPING) test1; -- set up FSM