mirrors/postgres
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Bound waits in 035_standby_logical_decoding.pl.

Browse Source 
One IPC::Run::start() used an IPC::Run::timer() without checking for
expiration.  The other used no timeout or timer.  Back-patch to v16,
which introduced the test.

Reviewed by Bertrand Drouvot.

Discussion: https://postgr.es/m/20240211010227.a2.nmisch@google.com
This commit is contained in:
Noah Misch 2024-02-19 12:52:07 -08:00
parent 7f27185324
commit 4791f87f34
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/test/recovery/t/035_standby_logical_decoding.pl
View File

@ -21,7 +21,6 @@ my $node_cascading_standby =
PostgreSQL::Test::Cluster->new('cascading_standby'); PostgreSQL::Test::Cluster->new('cascading_standby');
my $node_subscriber = PostgreSQL::Test::Cluster->new('subscriber'); my $node_subscriber = PostgreSQL::Test::Cluster->new('subscriber');
my $default_timeout = $PostgreSQL::Test::Utils::timeout_default; my $default_timeout = $PostgreSQL::Test::Utils::timeout_default;
my $psql_timeout = IPC::Run::timer($default_timeout);
my $res; my $res;
# Name for the physical slot on primary # Name for the physical slot on primary
@ -90,7 +89,8 @@ sub make_slot_active
'>', '>',
$to_stdout, $to_stdout,
'2>', '2>',
$to_stderr); $to_stderr,
IPC::Run::timeout($default_timeout));
if ($wait) if ($wait)
{ {
@ -341,7 +341,7 @@ $psql_subscriber{run} = IPC::Run::start(
\$psql_subscriber{subscriber_stdout}, \$psql_subscriber{subscriber_stdout},
'2>', '2>',
\$psql_subscriber{subscriber_stderr}, \$psql_subscriber{subscriber_stderr},
$psql_timeout); IPC::Run::timeout($default_timeout));
################################################## ##################################################
# Test that logical decoding on the standby # Test that logical decoding on the standby