Remove unnecessary casts in free() and pfree()
Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us> Discussion: https://www.postgresql.org/message-id/flat/cf26e970-8e92-59f1-247a-aa265235075b%40enterprisedb.com
This commit is contained in:
parent
121d2d3d70
commit
45987aae26
@ -662,28 +662,28 @@ quote_object_name(const char *src1, const char *src2,
|
||||
temp = quote_identifier(src1);
|
||||
appendStringInfoString(&result, temp);
|
||||
if (src1 != temp)
|
||||
pfree((void *) temp);
|
||||
pfree(temp);
|
||||
}
|
||||
if (src2)
|
||||
{
|
||||
temp = quote_identifier(src2);
|
||||
appendStringInfo(&result, ".%s", temp);
|
||||
if (src2 != temp)
|
||||
pfree((void *) temp);
|
||||
pfree(temp);
|
||||
}
|
||||
if (src3)
|
||||
{
|
||||
temp = quote_identifier(src3);
|
||||
appendStringInfo(&result, ".%s", temp);
|
||||
if (src3 != temp)
|
||||
pfree((void *) temp);
|
||||
pfree(temp);
|
||||
}
|
||||
if (src4)
|
||||
{
|
||||
temp = quote_identifier(src4);
|
||||
appendStringInfo(&result, ".%s", temp);
|
||||
if (src4 != temp)
|
||||
pfree((void *) temp);
|
||||
pfree(temp);
|
||||
}
|
||||
return result.data;
|
||||
}
|
||||
|
@ -240,7 +240,7 @@ internal_load_library(const char *libname)
|
||||
if (file_scanner->handle == NULL)
|
||||
{
|
||||
load_error = dlerror();
|
||||
free((char *) file_scanner);
|
||||
free(file_scanner);
|
||||
/* errcode_for_file_access might not be appropriate here? */
|
||||
ereport(ERROR,
|
||||
(errcode_for_file_access(),
|
||||
@ -263,7 +263,7 @@ internal_load_library(const char *libname)
|
||||
|
||||
/* try to close library */
|
||||
dlclose(file_scanner->handle);
|
||||
free((char *) file_scanner);
|
||||
free(file_scanner);
|
||||
|
||||
/* issue suitable complaint */
|
||||
incompatible_module_error(libname, &module_magic_data);
|
||||
@ -273,7 +273,7 @@ internal_load_library(const char *libname)
|
||||
{
|
||||
/* try to close library */
|
||||
dlclose(file_scanner->handle);
|
||||
free((char *) file_scanner);
|
||||
free(file_scanner);
|
||||
/* complain */
|
||||
ereport(ERROR,
|
||||
(errmsg("incompatible library \"%s\": missing magic block",
|
||||
|
Loading…
x
Reference in New Issue
Block a user