mirrors/postgres
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Reduce proc_exit(1) to proc_exit(0) for errors detected in backend

Browse Source 
command line processing.  As it stood, a bogus PGOPTIONS value from
a client would force a database system restart.  Not bad as a denial-
of-service attack...
This commit is contained in:
Tom Lane 2000-02-20 04:26:35 +00:00
parent e79b2dd5e7
commit 4467194b44
1 changed files with 8 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
src/backend/tcop/postgres.c
View File

@ -8,7 +8,7 @@
* *
* *
* IDENTIFICATION * IDENTIFICATION
* $Header: /cvsroot/pgsql/src/backend/tcop/postgres.c,v 1.143 2000/02/19 22:10:47 tgl Exp $ * $Header: /cvsroot/pgsql/src/backend/tcop/postgres.c,v 1.144 2000/02/20 04:26:35 tgl Exp $
* *
* NOTES * NOTES
* this is the "main" module of the postgres backend and * this is the "main" module of the postgres backend and
@ -1256,7 +1256,7 @@ PostgresMain(int argc, char *argv[], int real_argc, char *real_argv[])
(ShowParserStats || ShowPlannerStats || ShowExecutorStats)) (ShowParserStats || ShowPlannerStats || ShowExecutorStats))
{ {
fprintf(stderr, "-s can not be used together with -t.\n"); fprintf(stderr, "-s can not be used together with -t.\n");
proc_exit(1); proc_exit(0);
} }
if (!DataDir) if (!DataDir)
@ -1324,7 +1324,7 @@ PostgresMain(int argc, char *argv[], int real_argc, char *real_argv[])
if (errs || argc != optind || DBName == NULL) if (errs || argc != optind || DBName == NULL)
{ {
usage(argv[0]); usage(argv[0]);
proc_exit(1); proc_exit(0);
} }
pq_init(); /* initialize libpq at backend startup */ pq_init(); /* initialize libpq at backend startup */
whereToSendOutput = Remote; whereToSendOutput = Remote;
@ -1337,7 +1337,7 @@ PostgresMain(int argc, char *argv[], int real_argc, char *real_argv[])
if (errs || argc - optind > 1) if (errs || argc - optind > 1)
{ {
usage(argv[0]); usage(argv[0]);
proc_exit(1); proc_exit(0);
} }
else if (argc - optind == 1) else if (argc - optind == 1)
DBName = argv[optind]; DBName = argv[optind];
@ -1345,7 +1345,7 @@ PostgresMain(int argc, char *argv[], int real_argc, char *real_argv[])
{ {
fprintf(stderr, "%s: USER undefined and no database specified\n", fprintf(stderr, "%s: USER undefined and no database specified\n",
argv[0]); argv[0]);
proc_exit(1); proc_exit(0);
} }
/* /*
@ -1503,14 +1503,14 @@ PostgresMain(int argc, char *argv[], int real_argc, char *real_argv[])
if (!IsUnderPostmaster) if (!IsUnderPostmaster)
{ {
puts("\nPOSTGRES backend interactive interface "); puts("\nPOSTGRES backend interactive interface ");
puts("$Revision: 1.143 $ $Date: 2000/02/19 22:10:47 $\n"); puts("$Revision: 1.144 $ $Date: 2000/02/20 04:26:35 $\n");
} }
/* /*
* Initialize the deferred trigger manager * Initialize the deferred trigger manager
*/ */
if (DeferredTriggerInit() != 0) if (DeferredTriggerInit() != 0)
proc_exit(1); proc_exit(0);
SetProcessingMode(NormalProcessing); SetProcessingMode(NormalProcessing);