mirrors/postgres
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix various typos, grammar and code style in comments and docs

Browse Source 
This fixes a set of issues that have accumulated over the past months
(or years) in various code areas.  Most fixes are related to some recent
additions, as of the development of v15.

Author: Justin Pryzby
Discussion: https://postgr.es/m/20220124030001.GQ23027@telsasoft.com
This commit is contained in:
Michael Paquier 2022-01-25 09:40:04 +09:00
parent c817a072aa
commit 410aa248e5
44 changed files with 164 additions and 165 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
doc/src/sgml/config.sgml
View File

@ -8442,8 +8442,8 @@ COPY postgres_log FROM '/full/path/to/logfile.csv' WITH csv;
This parameter specifies the default table access method to use when This parameter specifies the default table access method to use when
creating tables or materialized views if the <command>CREATE</command> creating tables or materialized views if the <command>CREATE</command>
command does not explicitly specify an access method, or when command does not explicitly specify an access method, or when
<command>SELECT ... INTO</command> is used, which does not allow to <command>SELECT ... INTO</command> is used, which does not allow
specify a table access method. The default is <literal>heap</literal>. specifying a table access method. The default is <literal>heap</literal>.
</para> </para>
</listitem> </listitem>
</varlistentry> </varlistentry>

6
doc/src/sgml/ddl.sgml
View File

@ -1071,7 +1071,7 @@ CREATE TABLE order_items (
represent independent objects, then <literal>RESTRICT</literal> or represent independent objects, then <literal>RESTRICT</literal> or
<literal>NO ACTION</literal> is more appropriate; an application that <literal>NO ACTION</literal> is more appropriate; an application that
actually wants to delete both objects would then have to be explicit about actually wants to delete both objects would then have to be explicit about
this and run two delete options. In the above example, order items are this and run two delete commands. In the above example, order items are
part of an order, and it is convenient if they are deleted automatically part of an order, and it is convenient if they are deleted automatically
if an order is deleted. But products and orders are different things, and if an order is deleted. But products and orders are different things, and
so making a deletion of a product automatically cause the deletion of some so making a deletion of a product automatically cause the deletion of some
@ -4044,7 +4044,7 @@ ALTER TABLE measurement ATTACH PARTITION measurement_y2008m02
holding an <literal>ACCESS EXCLUSIVE</literal> lock on that partition. holding an <literal>ACCESS EXCLUSIVE</literal> lock on that partition.
It is recommended to drop the now-redundant <literal>CHECK</literal> It is recommended to drop the now-redundant <literal>CHECK</literal>
constraint after the <command>ATTACH PARTITION</command> is complete. If constraint after the <command>ATTACH PARTITION</command> is complete. If
the table being attached is itself a partitioned table then each of its the table being attached is itself a partitioned table, then each of its
sub-partitions will be recursively locked and scanned until either a sub-partitions will be recursively locked and scanned until either a
suitable <literal>CHECK</literal> constraint is encountered or the leaf suitable <literal>CHECK</literal> constraint is encountered or the leaf
partitions are reached. partitions are reached.
@ -4059,7 +4059,7 @@ ALTER TABLE measurement ATTACH PARTITION measurement_y2008m02
the partition being attached. This operation will be performed whilst the partition being attached. This operation will be performed whilst
holding an <literal>ACCESS EXCLUSIVE</literal> lock on the <literal> holding an <literal>ACCESS EXCLUSIVE</literal> lock on the <literal>
DEFAULT</literal> partition. If the <literal>DEFAULT</literal> partition DEFAULT</literal> partition. If the <literal>DEFAULT</literal> partition
is itself a partitioned table then each of its partitions will be is itself a partitioned table, then each of its partitions will be
recursively checked in the same way as the table being attached, as recursively checked in the same way as the table being attached, as
mentioned above. mentioned above.
</para> </para>

145
doc/src/sgml/func.sgml
View File

@ -27367,6 +27367,79 @@ SELECT pg_size_pretty(sum(pg_relation_size(relid))) AS total_size
</para></entry> </para></entry>
</row> </row>
<row>
<entry role="func_table_entry"><para role="func_signature">
<indexterm>
<primary>pg_ls_logicalmapdir</primary>
</indexterm>
<function>pg_ls_logicalmapdir</function> ()
<returnvalue>setof record</returnvalue>
( <parameter>name</parameter> <type>text</type>,
<parameter>size</parameter> <type>bigint</type>,
<parameter>modification</parameter> <type>timestamp with time zone</type> )
</para>
<para>
Returns the name, size, and last modification time (mtime) of each
ordinary file in the server's <filename>pg_logical/mappings</filename>
directory. Filenames beginning with a dot, directories, and other
special files are excluded.
</para>
<para>
This function is restricted to superusers and members of
the <literal>pg_monitor</literal> role by default, but other users can
be granted EXECUTE to run the function.
</para></entry>
</row>
<row>
<entry role="func_table_entry"><para role="func_signature">
<indexterm>
<primary>pg_ls_logicalsnapdir</primary>
</indexterm>
<function>pg_ls_logicalsnapdir</function> ()
<returnvalue>setof record</returnvalue>
( <parameter>name</parameter> <type>text</type>,
<parameter>size</parameter> <type>bigint</type>,
<parameter>modification</parameter> <type>timestamp with time zone</type> )
</para>
<para>
Returns the name, size, and last modification time (mtime) of each
ordinary file in the server's <filename>pg_logical/snapshots</filename>
directory. Filenames beginning with a dot, directories, and other
special files are excluded.
</para>
<para>
This function is restricted to superusers and members of
the <literal>pg_monitor</literal> role by default, but other users can
be granted EXECUTE to run the function.
</para></entry>
</row>
<row>
<entry role="func_table_entry"><para role="func_signature">
<indexterm>
<primary>pg_ls_replslotdir</primary>
</indexterm>
<function>pg_ls_replslotdir</function> ( <parameter>slot_name</parameter> <type>text</type> )
<returnvalue>setof record</returnvalue>
( <parameter>name</parameter> <type>text</type>,
<parameter>size</parameter> <type>bigint</type>,
<parameter>modification</parameter> <type>timestamp with time zone</type> )
</para>
<para>
Returns the name, size, and last modification time (mtime) of each
ordinary file in the server's <filename>pg_replslot/slot_name</filename>
directory, where <parameter>slot_name</parameter> is the name of the
replication slot provided as input of the function. Filenames beginning
with a dot, directories, and other special files are excluded.
</para>
<para>
This function is restricted to superusers and members of
the <literal>pg_monitor</literal> role by default, but other users can
be granted EXECUTE to run the function.
</para></entry>
</row>
<row> <row>
<entry role="func_table_entry"><para role="func_signature"> <entry role="func_table_entry"><para role="func_signature">
<indexterm> <indexterm>
@ -27498,78 +27571,6 @@ SELECT convert_from(pg_read_binary_file('file_in_utf8.txt'), 'UTF8');
</para></entry> </para></entry>
</row> </row>
<row>
<entry role="func_table_entry"><para role="func_signature">
<indexterm>
<primary>pg_ls_logicalsnapdir</primary>
</indexterm>
<function>pg_ls_logicalsnapdir</function> ()
<returnvalue>setof record</returnvalue>
( <parameter>name</parameter> <type>text</type>,
<parameter>size</parameter> <type>bigint</type>,
<parameter>modification</parameter> <type>timestamp with time zone</type> )
</para>
<para>
Returns the name, size, and last modification time (mtime) of each
ordinary file in the server's <filename>pg_logical/snapshots</filename>
directory. Filenames beginning with a dot, directories, and other
special files are excluded.
</para>
<para>
This function is restricted to superusers and members of
the <literal>pg_monitor</literal> role by default, but other users can
be granted EXECUTE to run the function.
</para></entry>
</row>
<row>
<entry role="func_table_entry"><para role="func_signature">
<indexterm>
<primary>pg_ls_logicalmapdir</primary>
</indexterm>
<function>pg_ls_logicalmapdir</function> ()
<returnvalue>setof record</returnvalue>
( <parameter>name</parameter> <type>text</type>,
<parameter>size</parameter> <type>bigint</type>,
<parameter>modification</parameter> <type>timestamp with time zone</type> )
</para>
<para>
Returns the name, size, and last modification time (mtime) of each
ordinary file in the server's <filename>pg_logical/mappings</filename>
directory. Filenames beginning with a dot, directories, and other
special files are excluded.
</para>
<para>
This function is restricted to superusers and members of
the <literal>pg_monitor</literal> role by default, but other users can
be granted EXECUTE to run the function.
</para></entry>
</row>
<row>
<entry role="func_table_entry"><para role="func_signature">
<indexterm>
<primary>pg_ls_replslotdir</primary>
</indexterm>
<function>pg_ls_replslotdir</function> ( <parameter>slot_name</parameter> <type>text</type> )
<returnvalue>setof record</returnvalue>
( <parameter>name</parameter> <type>text</type>,
<parameter>size</parameter> <type>bigint</type>,
<parameter>modification</parameter> <type>timestamp with time zone</type> )
</para>
<para>
Returns the name, size, and last modification time (mtime) of each
ordinary file in the server's <filename>pg_replslot/slot_name</filename>
directory, where <parameter>slot_name</parameter> is the name of the
replication slot provided as input of the function. Filenames beginning
with a dot, directories, and other special files are excluded.
</para>
<para>
This function is restricted to superusers and members of
the <literal>pg_monitor</literal> role by default, but other users can
be granted EXECUTE to run the function.
</para></entry>
</row>
</tbody> </tbody>
</tgroup> </tgroup>
</table> </table>

32
doc/src/sgml/glossary.sgml
View File

@ -1489,22 +1489,6 @@
</glossdef> </glossdef>
</glossentry> </glossentry>
<glossentry id="glossary-startup-process">
<glossterm>Startup process</glossterm>
<glossdef>
<para>
An <glossterm linkend="glossary-auxiliary-proc">auxiliary process</glossterm>
that replays WAL during crash recovery and in a
<glossterm linkend="glossary-replication">physical replica</glossterm>.
</para>
<para>
(The name is historical: the startup process was named before
replication was implemented; the name refers to its task as it
relates to the server startup following a crash.)
</para>
</glossdef>
</glossentry>
<glossentry id="glossary-sql-object"> <glossentry id="glossary-sql-object">
<glossterm>SQL object</glossterm> <glossterm>SQL object</glossterm>
<glossdef> <glossdef>
@ -1563,6 +1547,22 @@
<glosssee otherterm="glossary-replica" /> <glosssee otherterm="glossary-replica" />
</glossentry> </glossentry>
<glossentry id="glossary-startup-process">
<glossterm>Startup process</glossterm>
<glossdef>
<para>
An <glossterm linkend="glossary-auxiliary-proc">auxiliary process</glossterm>
that replays WAL during crash recovery and in a
<glossterm linkend="glossary-replication">physical replica</glossterm>.
</para>
<para>
(The name is historical: the startup process was named before
replication was implemented; the name refers to its task as it
relates to the server startup following a crash.)
</para>
</glossdef>
</glossentry>
<glossentry id="glossary-stats-collector"> <glossentry id="glossary-stats-collector">
<glossterm>Stats collector (process)</glossterm> <glossterm>Stats collector (process)</glossterm>
<glossdef> <glossdef>

2
doc/src/sgml/indexam.sgml
View File

@ -253,7 +253,7 @@ typedef struct IndexAmRoutine
access method blocks <acronym>HOT</acronym> when an indexed attribute is access method blocks <acronym>HOT</acronym> when an indexed attribute is
updated. Access methods without pointers to individual tuples (like updated. Access methods without pointers to individual tuples (like
<acronym>BRIN</acronym>) may allow <acronym>HOT</acronym> even in this <acronym>BRIN</acronym>) may allow <acronym>HOT</acronym> even in this
case. This does not apply to attributes referenced in index predicates, case. This does not apply to attributes referenced in index predicates;
an update of such attribute always disables <acronym>HOT</acronym>. an update of such attribute always disables <acronym>HOT</acronym>.
</para> </para>

2
doc/src/sgml/perform.sgml
View File

@ -1337,7 +1337,7 @@ nd | {"1, 2": 33178, "1, 5": 33178, "2, 5": 27435, "1, 2, 5": 33178}
<title>Multivariate MCV Lists</title> <title>Multivariate MCV Lists</title>
<para> <para>
Another type of statistics stored for each column are most-common value Another type of statistic stored for each column are most-common value
lists. This allows very accurate estimates for individual columns, but lists. This allows very accurate estimates for individual columns, but
may result in significant misestimates for queries with conditions on may result in significant misestimates for queries with conditions on
multiple columns. multiple columns.

12
doc/src/sgml/postgres-fdw.sgml
View File

@ -955,8 +955,8 @@ postgres=# SELECT postgres_fdw_disconnect_all();
of any length and contain even non-ASCII characters. However when of any length and contain even non-ASCII characters. However when
it's passed to and used as <varname>application_name</varname> it's passed to and used as <varname>application_name</varname>
in a foreign server, note that it will be truncated to less than in a foreign server, note that it will be truncated to less than
<symbol>NAMEDATALEN</symbol> characters and any characters other <symbol>NAMEDATALEN</symbol> characters and anything other than
than printable ASCII ones in it will be replaced with question than printable ASCII characters will be replaced with question
marks (<literal>?</literal>). marks (<literal>?</literal>).
See <xref linkend="guc-application-name"/> for details. See <xref linkend="guc-application-name"/> for details.
</para> </para>
@ -981,19 +981,19 @@ postgres=# SELECT postgres_fdw_disconnect_all();
<tbody> <tbody>
<row> <row>
<entry><literal>%a</literal></entry> <entry><literal>%a</literal></entry>
<entry>Application name in local server</entry> <entry>Application name on local server</entry>
</row> </row>
<row> <row>
<entry><literal>%u</literal></entry> <entry><literal>%u</literal></entry>
<entry>User name in local server</entry> <entry>User name on local server</entry>
</row> </row>
<row> <row>
<entry><literal>%d</literal></entry> <entry><literal>%d</literal></entry>
<entry>Database name in local server</entry> <entry>Database name on local server</entry>
</row> </row>
<row> <row>
<entry><literal>%p</literal></entry> <entry><literal>%p</literal></entry>
<entry>Process ID of backend in local server</entry> <entry>Process ID of backend on local server</entry>
</row> </row>
<row> <row>
<entry><literal>%%</literal></entry> <entry><literal>%%</literal></entry>

10
doc/src/sgml/protocol.sgml
View File

@ -2101,7 +2101,7 @@ The commands accepted in replication mode are:
</term> </term>
<listitem> <listitem>
<para> <para>
Read some information associated to a replication slot. Returns a tuple Read some information associated with a replication slot. Returns a tuple
with <literal>NULL</literal> values if the replication slot does not with <literal>NULL</literal> values if the replication slot does not
exist. This command is currently only supported for physical replication exist. This command is currently only supported for physical replication
slots. slots.
@ -2133,7 +2133,7 @@ The commands accepted in replication mode are:
<term><literal>restart_tli</literal> (<type>int8</type>)</term> <term><literal>restart_tli</literal> (<type>int8</type>)</term>
<listitem> <listitem>
<para> <para>
The timeline ID associated to <literal>restart_lsn</literal>, The timeline ID associated with <literal>restart_lsn</literal>,
following the current timeline history. following the current timeline history.
</para> </para>
</listitem> </listitem>
@ -2155,7 +2155,7 @@ The commands accepted in replication mode are:
streaming starts on timeline <replaceable class="parameter">tli</replaceable>; streaming starts on timeline <replaceable class="parameter">tli</replaceable>;
otherwise, the server's current timeline is selected. The server can otherwise, the server's current timeline is selected. The server can
reply with an error, for example if the requested section of WAL has already reply with an error, for example if the requested section of WAL has already
been recycled. On success, server responds with a CopyBothResponse been recycled. On success, the server responds with a CopyBothResponse
message, and then starts to stream WAL to the frontend. message, and then starts to stream WAL to the frontend.
</para> </para>
@ -2516,7 +2516,7 @@ The commands accepted in replication mode are:
<para> <para>
The server can reply with an error, for example if the The server can reply with an error, for example if the
slot does not exist. On success, server responds with a CopyBothResponse slot does not exist. On success, the server responds with a CopyBothResponse
message, and then starts to stream WAL to the frontend. message, and then starts to stream WAL to the frontend.
</para> </para>
@ -6680,7 +6680,7 @@ not line breaks.
<para> <para>
This section describes the detailed format of each logical replication This section describes the detailed format of each logical replication
message. These messages are either returned by the replication slot SQL message. These messages are either returned by the replication slot SQL
interface or are sent by a walsender. In the case of a walsender they are interface or are sent by a walsender. In the case of a walsender, they are
encapsulated inside replication protocol WAL messages as described in encapsulated inside replication protocol WAL messages as described in
<xref linkend="protocol-replication"/>, and generally obey the same message <xref linkend="protocol-replication"/>, and generally obey the same message
flow as physical replication. flow as physical replication.

4
doc/src/sgml/ref/alter_publication.sgml
View File

@ -50,7 +50,7 @@ ALTER PUBLICATION <replaceable class="parameter">name</replaceable> RENAME TO <r
tables/schemas that were present in the publication will be removed. The tables/schemas that were present in the publication will be removed. The
<literal>ADD</literal> and <literal>DROP</literal> clauses will add and <literal>ADD</literal> and <literal>DROP</literal> clauses will add and
remove one or more tables/schemas from the publication. Note that adding remove one or more tables/schemas from the publication. Note that adding
tables/schemas to a publication that is already subscribed to will require a tables/schemas to a publication that is already subscribed to will require an
<literal>ALTER SUBSCRIPTION ... REFRESH PUBLICATION</literal> action on the <literal>ALTER SUBSCRIPTION ... REFRESH PUBLICATION</literal> action on the
subscribing side in order to become effective. subscribing side in order to become effective.
</para> </para>
@ -82,7 +82,7 @@ ALTER PUBLICATION <replaceable class="parameter">name</replaceable> RENAME TO <r
<para> <para>
Adding/Setting a table that is part of schema specified in Adding/Setting a table that is part of schema specified in
<literal>ALL TABLES IN SCHEMA</literal>, adding/setting a schema to a <literal>ALL TABLES IN SCHEMA</literal>, adding/setting a schema to a
publication that already has a table that is part of specified schema or publication that already has a table that is part of the specified schema or
adding/setting a table to a publication that already has a table's schema as adding/setting a table to a publication that already has a table's schema as
part of the specified schema is not supported. part of the specified schema is not supported.
</para> </para>

8
doc/src/sgml/ref/create_publication.sgml
View File

@ -131,9 +131,9 @@ CREATE PUBLICATION <replaceable class="parameter">name</replaceable>
<para> <para>
When a partitioned table is published via schema level publication, all When a partitioned table is published via schema level publication, all
of its existing and future partitions irrespective of it being from the of its existing and future partitions are implicitly considered to be part of the
publication schema or not are implicitly considered to be part of the publication, regardless of whether they are from the publication schema or not.
publication. So, even operations that are performed directly on a So, even operations that are performed directly on a
partition are also published via publications that its ancestors are partition are also published via publications that its ancestors are
part of. part of.
</para> </para>
@ -195,7 +195,7 @@ CREATE PUBLICATION <replaceable class="parameter">name</replaceable>
<para> <para>
If <literal>FOR TABLE</literal>, <literal>FOR ALL TABLES</literal> or If <literal>FOR TABLE</literal>, <literal>FOR ALL TABLES</literal> or
<literal>FOR ALL TABLES IN SCHEMA</literal> is not specified, then the <literal>FOR ALL TABLES IN SCHEMA</literal> are not specified, then the
publication starts out with an empty set of tables. That is useful if publication starts out with an empty set of tables. That is useful if
tables or schemas are to be added later. tables or schemas are to be added later.
</para> </para>

11
doc/src/sgml/ref/pg_receivewal.sgml
View File

@ -82,9 +82,8 @@ PostgreSQL documentation
<listitem> <listitem>
<para> <para>
First, scan the directory where the WAL segment files are written and First, scan the directory where the WAL segment files are written and
find the newest completed segment file, using as starting point the find the newest completed segment file, using as the starting point the
beginning of the next WAL segment file. This is calculated independently beginning of the next WAL segment file.
on the compression method used to compress each segment.
</para> </para>
</listitem> </listitem>
@ -93,7 +92,7 @@ PostgreSQL documentation
If a starting point cannot be calculated with the previous method, If a starting point cannot be calculated with the previous method,
and if a replication slot is used, an extra and if a replication slot is used, an extra
<command>READ_REPLICATION_SLOT</command> command is issued to retrieve <command>READ_REPLICATION_SLOT</command> command is issued to retrieve
the slot's <literal>restart_lsn</literal> to use as starting point. the slot's <literal>restart_lsn</literal> to use as the starting point.
This option is only available when streaming write-ahead logs from This option is only available when streaming write-ahead logs from
<productname>PostgreSQL</productname> 15 and up. <productname>PostgreSQL</productname> 15 and up.
</para> </para>
@ -103,7 +102,7 @@ PostgreSQL documentation
<para> <para>
If a starting point cannot be calculated with the previous method, If a starting point cannot be calculated with the previous method,
the latest WAL flush location is used as reported by the server from the latest WAL flush location is used as reported by the server from
a <literal>IDENTIFY_SYSTEM</literal> command. an <literal>IDENTIFY_SYSTEM</literal> command.
</para> </para>
</listitem> </listitem>
</orderedlist> </orderedlist>
@ -268,7 +267,7 @@ PostgreSQL documentation
<listitem> <listitem>
<para> <para>
Enables compression of write-ahead logs using the specified method. Enables compression of write-ahead logs using the specified method.
Supported values <literal>gzip</literal>, <literal>lz4</literal> Supported values are <literal>gzip</literal>, <literal>lz4</literal>
(if <productname>PostgreSQL</productname> was compiled with (if <productname>PostgreSQL</productname> was compiled with
<option>--with-lz4</option>), and <literal>none</literal>. <option>--with-lz4</option>), and <literal>none</literal>.
</para> </para>

4
doc/src/sgml/ref/pgbench.sgml
View File

@ -220,8 +220,8 @@ pgbench <optional> <replaceable>options</replaceable> </optional> <replaceable>d
data is generated in <command>pgbench</command> client and then data is generated in <command>pgbench</command> client and then
sent to the server. This uses the client/server bandwidth sent to the server. This uses the client/server bandwidth
extensively through a <command>COPY</command>. extensively through a <command>COPY</command>.
<command>pgbench</command> uses the FREEZE option with 14 or later <command>pgbench</command> uses the FREEZE option with version 14 or later
versions of <productname>PostgreSQL</productname> to speed up of <productname>PostgreSQL</productname> to speed up
subsequent <command>VACUUM</command>, unless partitions are enabled. subsequent <command>VACUUM</command>, unless partitions are enabled.
Using <literal>g</literal> causes logging to print one message Using <literal>g</literal> causes logging to print one message
every 100,000 rows while generating data for the every 100,000 rows while generating data for the

2
doc/src/sgml/ref/pgupgrade.sgml
View File

@ -139,7 +139,7 @@ PostgreSQL documentation
of the upgraded cluster to be written safely to disk. This option of the upgraded cluster to be written safely to disk. This option
causes <command>pg_upgrade</command> to return without waiting, which causes <command>pg_upgrade</command> to return without waiting, which
is faster, but means that a subsequent operating system crash can leave is faster, but means that a subsequent operating system crash can leave
the synchronized data directory corrupt. Generally, this option is the data directory corrupt. Generally, this option is
useful for testing but should not be used on a production useful for testing but should not be used on a production
installation. installation.
</para> </para>

2
doc/src/sgml/ref/select_into.sgml
View File

@ -107,7 +107,7 @@ SELECT [ ALL | DISTINCT [ ON ( <replaceable class="parameter">expression</replac
<para> <para>
In contrast to <command>CREATE TABLE AS</command>, <command>SELECT In contrast to <command>CREATE TABLE AS</command>, <command>SELECT
INTO</command> does not allow to specify properties like a table's access INTO</command> does not allow specifying properties like a table's access
method with <xref linkend="sql-createtable-method" /> or the table's method with <xref linkend="sql-createtable-method" /> or the table's
tablespace with <xref linkend="sql-createtable-tablespace" />. Use tablespace with <xref linkend="sql-createtable-tablespace" />. Use
<command>CREATE TABLE AS</command> if necessary. Therefore, the default table <command>CREATE TABLE AS</command> if necessary. Therefore, the default table

2
src/backend/access/gin/ginget.c
View File

@ -1319,7 +1319,7 @@ scanGetItem(IndexScanDesc scan, ItemPointerData advancePast,
GinScanKey key = so->keys + i; GinScanKey key = so->keys + i;
/* /*
* If we're considering a lossy page, skip excludeOnly keys, They * If we're considering a lossy page, skip excludeOnly keys. They
* can't exclude the whole page anyway. * can't exclude the whole page anyway.
*/ */
if (ItemPointerIsLossyPage(item) && key->excludeOnly) if (ItemPointerIsLossyPage(item) && key->excludeOnly)

2
src/backend/access/heap/heapam.c
View File

@ -8354,7 +8354,7 @@ log_heap_new_cid(Relation relation, HeapTuple tup)
/* /*
* Build a heap tuple representing the configured REPLICA IDENTITY to represent * Build a heap tuple representing the configured REPLICA IDENTITY to represent
* the old tuple in a UPDATE or DELETE. * the old tuple in an UPDATE or DELETE.
* *
* Returns NULL if there's no need to log an identity or if there's no suitable * Returns NULL if there's no need to log an identity or if there's no suitable
* key defined. * key defined.

1
src/backend/access/transam/xlog.c
View File

@ -2706,7 +2706,6 @@ XLogWrite(XLogwrtRqst WriteRqst, TimeLineID tli, bool flexible)
*/ */
if (LogwrtResult.Flush < WriteRqst.Flush && if (LogwrtResult.Flush < WriteRqst.Flush &&
LogwrtResult.Flush < LogwrtResult.Write) LogwrtResult.Flush < LogwrtResult.Write)
{ {
/* /*
* Could get here without iterating above loop, in which case we might * Could get here without iterating above loop, in which case we might

2
src/backend/catalog/pg_publication.c
View File

@ -7,7 +7,7 @@
* Portions Copyright (c) 1994, Regents of the University of California * Portions Copyright (c) 1994, Regents of the University of California
* *
* IDENTIFICATION * IDENTIFICATION
* pg_publication.c * src/backend/catalog/pg_publication.c
* *
*------------------------------------------------------------------------- *-------------------------------------------------------------------------
*/ */

2
src/backend/commands/cluster.c
View File

@ -906,7 +906,7 @@ copy_table_data(Oid OIDNewHeap, Oid OIDOldHeap, Oid OIDOldIndex, bool verbose,
RelationGetRelationName(OldHeap)))); RelationGetRelationName(OldHeap))));
/* /*
* Hand of the actual copying to AM specific function, the generic code * Hand off the actual copying to AM specific function, the generic code
* cannot know how to deal with visibility across AMs. Note that this * cannot know how to deal with visibility across AMs. Note that this
* routine is allowed to set FreezeXid / MultiXactCutoff to different * routine is allowed to set FreezeXid / MultiXactCutoff to different
* values (e.g. because the AM doesn't use freezing). * values (e.g. because the AM doesn't use freezing).

2
src/backend/commands/indexcmds.c
View File

@ -2219,7 +2219,7 @@ makeObjectName(const char *name1, const char *name2, const char *label)
Assert(availchars > 0); /* else caller chose a bad label */ Assert(availchars > 0); /* else caller chose a bad label */
/* /*
* If we must truncate, preferentially truncate the longer name. This * If we must truncate, preferentially truncate the longer name. This
* logic could be expressed without a loop, but it's simple and obvious as * logic could be expressed without a loop, but it's simple and obvious as
* a loop. * a loop.
*/ */

2
src/backend/commands/publicationcmds.c
View File

@ -7,7 +7,7 @@
* Portions Copyright (c) 1994, Regents of the University of California * Portions Copyright (c) 1994, Regents of the University of California
* *
* IDENTIFICATION * IDENTIFICATION
* publicationcmds.c * src/backend/commands/publicationcmds.c
* *
*------------------------------------------------------------------------- *-------------------------------------------------------------------------
*/ */

2
src/backend/commands/subscriptioncmds.c
View File

@ -7,7 +7,7 @@
* Portions Copyright (c) 1994, Regents of the University of California * Portions Copyright (c) 1994, Regents of the University of California
* *
* IDENTIFICATION * IDENTIFICATION
* subscriptioncmds.c * src/backend/commands/subscriptioncmds.c
* *
*------------------------------------------------------------------------- *-------------------------------------------------------------------------
*/ */

2
src/backend/optimizer/util/appendinfo.c
View File

@ -8,7 +8,7 @@
* *
* *
* IDENTIFICATION * IDENTIFICATION
* src/backend/optimizer/path/appendinfo.c * src/backend/optimizer/util/appendinfo.c
* *
*------------------------------------------------------------------------- *-------------------------------------------------------------------------
*/ */

2
src/backend/optimizer/util/inherit.c
View File

@ -8,7 +8,7 @@
* *
* *
* IDENTIFICATION * IDENTIFICATION
* src/backend/optimizer/path/inherit.c * src/backend/optimizer/util/inherit.c
* *
*------------------------------------------------------------------------- *-------------------------------------------------------------------------
*/ */

2
src/backend/replication/logical/logicalfuncs.c
View File

@ -9,7 +9,7 @@
* Copyright (c) 2012-2022, PostgreSQL Global Development Group * Copyright (c) 2012-2022, PostgreSQL Global Development Group
* *
* IDENTIFICATION * IDENTIFICATION
* src/backend/replication/logicalfuncs.c * src/backend/replication/logical/logicalfuncs.c
*------------------------------------------------------------------------- *-------------------------------------------------------------------------
*/ */

2
src/backend/replication/logical/reorderbuffer.c
View File

@ -8,7 +8,7 @@
* *
* *
* IDENTIFICATION * IDENTIFICATION
* src/backend/replication/reorderbuffer.c * src/backend/replication/logical/reorderbuffer.c
* *
* NOTES * NOTES
* This module gets handed individual pieces of transactions in the order * This module gets handed individual pieces of transactions in the order

2
src/backend/replication/logical/snapbuild.c
View File

@ -110,7 +110,7 @@
* Copyright (c) 2012-2022, PostgreSQL Global Development Group * Copyright (c) 2012-2022, PostgreSQL Global Development Group
* *
* IDENTIFICATION * IDENTIFICATION
* src/backend/replication/snapbuild.c * src/backend/replication/logical/snapbuild.c
* *
*------------------------------------------------------------------------- *-------------------------------------------------------------------------
*/ */

8
src/backend/replication/logical/worker.c
View File

@ -2368,7 +2368,7 @@ apply_dispatch(StringInfo s)
/* /*
* Set the current command being applied. Since this function can be * Set the current command being applied. Since this function can be
* called recusively when applying spooled changes, save the current * called recursively when applying spooled changes, save the current
* command. * command.
*/ */
saved_command = apply_error_callback_arg.command; saved_command = apply_error_callback_arg.command;
@ -2587,8 +2587,8 @@ LogicalRepApplyLoop(XLogRecPtr last_received)
pgstat_report_activity(STATE_IDLE, NULL); pgstat_report_activity(STATE_IDLE, NULL);
/* /*
* Push apply error context callback. Fields will be filled during * Push apply error context callback. Fields will be filled while applying
* applying a change. * a change.
*/ */
errcallback.callback = apply_error_callback; errcallback.callback = apply_error_callback;
errcallback.previous = error_context_stack; errcallback.previous = error_context_stack;
@ -3608,7 +3608,7 @@ ApplyWorkerMain(Datum main_arg)
} }
ereport(DEBUG1, ereport(DEBUG1,
(errmsg("logical replication apply worker for subscription \"%s\" two_phase is %s.", (errmsg("logical replication apply worker for subscription \"%s\" two_phase is %s",
MySubscription->name, MySubscription->name,
MySubscription->twophasestate == LOGICALREP_TWOPHASE_STATE_DISABLED ? "DISABLED" : MySubscription->twophasestate == LOGICALREP_TWOPHASE_STATE_DISABLED ? "DISABLED" :
MySubscription->twophasestate == LOGICALREP_TWOPHASE_STATE_PENDING ? "PENDING" : MySubscription->twophasestate == LOGICALREP_TWOPHASE_STATE_PENDING ? "PENDING" :

2
src/backend/statistics/extended_stats.c
View File

@ -958,7 +958,7 @@ compare_datums_simple(Datum a, Datum b, SortSupport ssup)
* build_attnums_array * build_attnums_array
* Transforms a bitmap into an array of AttrNumber values. * Transforms a bitmap into an array of AttrNumber values.
* *
* This is used for extended statistics only, so all the attribute must be * This is used for extended statistics only, so all the attributes must be
* user-defined. That means offsetting by FirstLowInvalidHeapAttributeNumber * user-defined. That means offsetting by FirstLowInvalidHeapAttributeNumber
* is not necessary here (and when querying the bitmap). * is not necessary here (and when querying the bitmap).
*/ */

8
src/backend/statistics/mcv.c
View File

@ -134,7 +134,7 @@ static int count_distinct_groups(int numrows, SortItem *items,
* This bound is at most 25, and approaches 0 as n approaches 0 or N. The * This bound is at most 25, and approaches 0 as n approaches 0 or N. The
* case where n approaches 0 cannot happen in practice, since the sample * case where n approaches 0 cannot happen in practice, since the sample
* size is at least 300. The case where n approaches N corresponds to * size is at least 300. The case where n approaches N corresponds to
* sampling the whole the table, in which case it is reasonable to keep * sampling the whole table, in which case it is reasonable to keep
* the whole MCV list (have no lower bound), so it makes sense to apply * the whole MCV list (have no lower bound), so it makes sense to apply
* this formula for all inputs, even though the above derivation is * this formula for all inputs, even though the above derivation is
* technically only valid when the right hand side is at least around 10. * technically only valid when the right hand side is at least around 10.
@ -295,7 +295,7 @@ statext_mcv_build(StatsBuildData *data, double totalrows, int stattarget)
/* Copy the first chunk of groups into the result. */ /* Copy the first chunk of groups into the result. */
for (i = 0; i < nitems; i++) for (i = 0; i < nitems; i++)
{ {
/* just pointer to the proper place in the list */ /* just point to the proper place in the list */
MCVItem *item = &mcvlist->items[i]; MCVItem *item = &mcvlist->items[i];
item->values = (Datum *) palloc(sizeof(Datum) * numattrs); item->values = (Datum *) palloc(sizeof(Datum) * numattrs);
@ -556,7 +556,7 @@ build_column_frequencies(SortItem *groups, int ngroups,
/* /*
* statext_mcv_load * statext_mcv_load
* Load the MCV list for the indicated pg_statistic_ext tuple. * Load the MCV list for the indicated pg_statistic_ext_data tuple.
*/ */
MCVList * MCVList *
statext_mcv_load(Oid mvoid, bool inh) statext_mcv_load(Oid mvoid, bool inh)
@ -1620,7 +1620,7 @@ mcv_get_match_bitmap(PlannerInfo *root, List *clauses,
Assert(mcvlist->nitems <= STATS_MCVLIST_MAX_ITEMS); Assert(mcvlist->nitems <= STATS_MCVLIST_MAX_ITEMS);
matches = palloc(sizeof(bool) * mcvlist->nitems); matches = palloc(sizeof(bool) * mcvlist->nitems);
memset(matches, !is_or, sizeof(bool) * mcvlist->nitems); memset(matches, !is_or, sizeof(bool) * mcvlist->nitems);
/* /*
* Loop through the list of clauses, and for each of them evaluate all the * Loop through the list of clauses, and for each of them evaluate all the

1
src/backend/storage/sync/sync.c
View File

@ -274,7 +274,6 @@ SyncPostCheckpoint(void)
} }
/* /*
* ProcessSyncRequests() -- Process queued fsync requests. * ProcessSyncRequests() -- Process queued fsync requests.
*/ */
void void

4
src/backend/utils/activity/backend_progress.c
View File

@ -1,11 +1,11 @@
/* ---------- /* ----------
* progress.c * backend_progress.c
* *
* Command progress reporting infrastructure. * Command progress reporting infrastructure.
* *
* Copyright (c) 2001-2022, PostgreSQL Global Development Group * Copyright (c) 2001-2022, PostgreSQL Global Development Group
* *
* src/backend/postmaster/progress.c * src/backend/utils/activity/backend_progress.c
* ---------- * ----------
*/ */
#include "postgres.h" #include "postgres.h"

2
src/backend/utils/activity/backend_status.c
View File

@ -6,7 +6,7 @@
* *
* *
* IDENTIFICATION * IDENTIFICATION
* src/backend/postmaster/backend_status.c * src/backend/utils/activity/backend_status.c
* ---------- * ----------
*/ */
#include "postgres.h" #include "postgres.h"

2
src/backend/utils/activity/wait_event.c
View File

@ -6,7 +6,7 @@
* *
* *
* IDENTIFICATION * IDENTIFICATION
* src/backend/postmaster/wait_event.c * src/backend/utils/activity/wait_event.c
* *
* NOTES * NOTES
* *

4
src/bin/psql/describe.c
View File

@ -2652,8 +2652,8 @@ describeOneTableDetails(const char *schemaname,
/* /*
* When printing kinds we ignore expression statistics, * When printing kinds we ignore expression statistics,
* which is used only internally and can't be specified by * which are used only internally and can't be specified
* user. We don't print the kinds when either none are * by user. We don't print the kinds when none are
* specified (in which case it has to be statistics on a * specified (in which case it has to be statistics on a
* single expr) or when all are specified (in which case * single expr) or when all are specified (in which case
* we assume it's expanded by CREATE STATISTICS). * we assume it's expanded by CREATE STATISTICS).

2
src/include/replication/pgoutput.h
View File

@ -6,7 +6,7 @@
* Copyright (c) 2015-2022, PostgreSQL Global Development Group * Copyright (c) 2015-2022, PostgreSQL Global Development Group
* *
* IDENTIFICATION * IDENTIFICATION
* pgoutput.h * src/include/replication/pgoutput.h
* *
*------------------------------------------------------------------------- *-------------------------------------------------------------------------
*/ */

5
src/include/utils/dynahash.h
View File

@ -1,13 +1,14 @@
/*------------------------------------------------------------------------- /*-------------------------------------------------------------------------
* *
* dynahash * dynahash.h
* POSTGRES dynahash.h file definitions * POSTGRES dynahash.h file definitions
* *
* *
* Portions Copyright (c) 1996-2022, PostgreSQL Global Development Group * Portions Copyright (c) 1996-2022, PostgreSQL Global Development Group
* Portions Copyright (c) 1994, Regents of the University of California * Portions Copyright (c) 1994, Regents of the University of California
* *
* src/include/utils/dynahash.h * IDENTIFICATION
* src/include/utils/dynahash.h
* *
*------------------------------------------------------------------------- *-------------------------------------------------------------------------
*/ */

2
src/pl/plperl/plperl.c
View File

@ -334,7 +334,7 @@ hek2cstr(HE *he)
SAVETMPS; SAVETMPS;
/*------------------------- /*-------------------------
* Unfortunately, while HeUTF8 is true for most things > 256, for values * Unfortunately, while HeUTF8 is true for most things > 256, for values
* 128..255 it's not, but perl will treat them as unicode code points if * 128..255 it's not, but perl will treat them as unicode code points if
* the utf8 flag is not set ( see The "Unicode Bug" in perldoc perlunicode * the utf8 flag is not set ( see The "Unicode Bug" in perldoc perlunicode
* for more) * for more)

4
src/port/pgcheckdir.c
View File

@ -1,6 +1,6 @@
/*------------------------------------------------------------------------- /*-------------------------------------------------------------------------
* *
* src/port/pgcheckdir.c * pgcheckdir.c
* *
* A simple subroutine to check whether a directory exists and is empty or not. * A simple subroutine to check whether a directory exists and is empty or not.
* Useful in both initdb and the backend. * Useful in both initdb and the backend.
@ -8,6 +8,8 @@
* Portions Copyright (c) 1996-2022, PostgreSQL Global Development Group * Portions Copyright (c) 1996-2022, PostgreSQL Global Development Group
* Portions Copyright (c) 1994, Regents of the University of California * Portions Copyright (c) 1994, Regents of the University of California
* *
* IDENTIFICATION
* src/port/pgcheckdir.c
*------------------------------------------------------------------------- *-------------------------------------------------------------------------
*/ */

4
src/test/modules/unsafe_tests/expected/alter_system_table.out
View File

@ -53,7 +53,7 @@ ERROR: permission denied: "pg_description" is a system catalog
CREATE TABLE foo (a oid, b oid, c int, FOREIGN KEY (a, b, c) REFERENCES pg_description); CREATE TABLE foo (a oid, b oid, c int, FOREIGN KEY (a, b, c) REFERENCES pg_description);
ERROR: permission denied: "pg_description" is a system catalog ERROR: permission denied: "pg_description" is a system catalog
-- RangeVarCallbackOwnsRelation() -- RangeVarCallbackOwnsRelation()
CREATE INDEX pg_descripton_test_index ON pg_description (description); CREATE INDEX pg_description_test_index ON pg_description (description);
ERROR: permission denied: "pg_description" is a system catalog ERROR: permission denied: "pg_description" is a system catalog
-- RangeVarCallbackForAlterRelation() -- RangeVarCallbackForAlterRelation()
ALTER TABLE pg_description RENAME TO pg_comment; ALTER TABLE pg_description RENAME TO pg_comment;
@ -151,7 +151,7 @@ CREATE TABLE foo (a oid, b oid, c int, FOREIGN KEY (a, b, c) REFERENCES pg_descr
ROLLBACK; ROLLBACK;
-- RangeVarCallbackOwnsRelation() -- RangeVarCallbackOwnsRelation()
BEGIN; BEGIN;
CREATE INDEX pg_descripton_test_index ON pg_description (description); CREATE INDEX pg_description_test_index ON pg_description (description);
ROLLBACK; ROLLBACK;
-- RangeVarCallbackForAlterRelation() -- RangeVarCallbackForAlterRelation()
BEGIN; BEGIN;

4
src/test/modules/unsafe_tests/sql/alter_system_table.sql
View File

@ -55,7 +55,7 @@ ALTER TABLE pg_description ALTER COLUMN description SET STATISTICS -1;
CREATE TABLE foo (a oid, b oid, c int, FOREIGN KEY (a, b, c) REFERENCES pg_description); CREATE TABLE foo (a oid, b oid, c int, FOREIGN KEY (a, b, c) REFERENCES pg_description);
-- RangeVarCallbackOwnsRelation() -- RangeVarCallbackOwnsRelation()
CREATE INDEX pg_descripton_test_index ON pg_description (description); CREATE INDEX pg_description_test_index ON pg_description (description);
-- RangeVarCallbackForAlterRelation() -- RangeVarCallbackForAlterRelation()
ALTER TABLE pg_description RENAME TO pg_comment; ALTER TABLE pg_description RENAME TO pg_comment;
@ -161,7 +161,7 @@ ROLLBACK;
-- RangeVarCallbackOwnsRelation() -- RangeVarCallbackOwnsRelation()
BEGIN; BEGIN;
CREATE INDEX pg_descripton_test_index ON pg_description (description); CREATE INDEX pg_description_test_index ON pg_description (description);
ROLLBACK; ROLLBACK;
-- RangeVarCallbackForAlterRelation() -- RangeVarCallbackForAlterRelation()

2
src/test/regress/expected/sysviews.out
View File

@ -20,7 +20,7 @@ select count(*) >= 0 as ok from pg_available_extensions;
(1 row) (1 row)
-- The entire output of pg_backend_memory_contexts is not stable, -- The entire output of pg_backend_memory_contexts is not stable,
-- we test only the existance and basic condition of TopMemoryContext. -- we test only the existence and basic condition of TopMemoryContext.
select name, ident, parent, level, total_bytes >= free_bytes select name, ident, parent, level, total_bytes >= free_bytes
from pg_backend_memory_contexts where level = 0; from pg_backend_memory_contexts where level = 0;
name | ident | parent | level | ?column? name | ident | parent | level | ?column?

2
src/test/regress/sql/sysviews.sql
View File

@ -13,7 +13,7 @@ select count(*) >= 0 as ok from pg_available_extension_versions;
select count(*) >= 0 as ok from pg_available_extensions; select count(*) >= 0 as ok from pg_available_extensions;
-- The entire output of pg_backend_memory_contexts is not stable, -- The entire output of pg_backend_memory_contexts is not stable,
-- we test only the existance and basic condition of TopMemoryContext. -- we test only the existence and basic condition of TopMemoryContext.
select name, ident, parent, level, total_bytes >= free_bytes select name, ident, parent, level, total_bytes >= free_bytes
from pg_backend_memory_contexts where level = 0; from pg_backend_memory_contexts where level = 0;

4
src/tools/msvc/vcregress.pl
View File

@ -538,7 +538,6 @@ sub recoverycheck
$ENV{REGRESS_OUTPUTDIR} = "$topdir/src/test/recovery/tmp_check"; $ENV{REGRESS_OUTPUTDIR} = "$topdir/src/test/recovery/tmp_check";
my $mstat = 0;
my $dir = "$topdir/src/test/recovery"; my $dir = "$topdir/src/test/recovery";
my $status = tap_check($dir); my $status = tap_check($dir);
exit $status if $status; exit $status if $status;
@ -717,7 +716,6 @@ sub fetchRegressOpts
# list is returned if the module does not need to run anything. # list is returned if the module does not need to run anything.
sub fetchTests sub fetchTests
{ {
my $handle; my $handle;
open($handle, '<', "GNUmakefile") open($handle, '<', "GNUmakefile")
|| open($handle, '<', "Makefile") || open($handle, '<', "Makefile")
@ -783,7 +781,7 @@ sub InstallTemp
sub usage sub usage
{ {
print STDERR print STDERR
"Usage: vcregress.pl <mode> [ <arg>]\n\n", "Usage: vcregress.pl <mode> [<arg>]\n\n",
"Options for <mode>:\n", "Options for <mode>:\n",
" bincheck run tests of utilities in src/bin/\n", " bincheck run tests of utilities in src/bin/\n",
" check deploy instance and run regression tests on it\n", " check deploy instance and run regression tests on it\n",