mirrors/postgres
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Check after errors of SPI_execute() in xml.c

Browse Source 
SPI gets used to build a list of relation OIDs for XML object
generation, and one code path building a list uses SPI_execute() without
looking at errors it produces.  So fix that.

Author: Mark Dilger
Reviewed-by: Michael Paquier, Pavel Stehule
Discussion: https://postgr.es/m/17d30445-4862-7917-170f-84328dcd292d@gmail.com
This commit is contained in:
Michael Paquier 2019-11-07 11:13:31 +09:00
parent 6e3e6cc0e8
commit 3feb6ace7c
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/backend/utils/adt/xml.c
View File

@ -2461,8 +2461,12 @@ query_to_oid_list(const char *query)
{
uint64 i;
List *list = NIL;
int spi_result;
SPI_execute(query, true, 0);
spi_result = SPI_execute(query, true, 0);
if (spi_result != SPI_OK_SELECT)
elog(ERROR, "SPI_execute returned %s for %s",
SPI_result_code_string(spi_result), query);
for (i = 0; i < SPI_processed; i++)
{