From 3e60e956b0017ae9d329bf242e76c4487fb39b4d Mon Sep 17 00:00:00 2001 From: Heikki Linnakangas <heikki.linnakangas@iki.fi> Date: Mon, 8 Apr 2024 05:03:17 +0300 Subject: [PATCH] Fix check for 'outlen' return from SSL_select_next_proto() Fixes compiler warning reported by Andres Freund. Discusssion: https://www.postgresql.org/message-id/20240408015055.xsuahullywpfwyvu@awork3.anarazel.de --- src/backend/libpq/be-secure-openssl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/backend/libpq/be-secure-openssl.c b/src/backend/libpq/be-secure-openssl.c index 6e877c0173..29c9af1aab 100644 --- a/src/backend/libpq/be-secure-openssl.c +++ b/src/backend/libpq/be-secure-openssl.c @@ -1324,7 +1324,7 @@ alpn_cb(SSL *ssl, retval = SSL_select_next_proto((unsigned char **) out, outlen, alpn_protos, sizeof(alpn_protos), in, inlen); - if (*out == NULL || *outlen > sizeof(alpn_protos) || outlen <= 0) + if (*out == NULL || *outlen > sizeof(alpn_protos) || *outlen <= 0) return SSL_TLSEXT_ERR_NOACK; /* can't happen */ if (retval == OPENSSL_NPN_NEGOTIATED)