mirrors/postgres
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Add an explicit caution about how to use pg_do_encoding_conversion with

Browse Source 
non-null-terminated input.  Per discussion with ITAGAKI Takahiro.
This commit is contained in:
Tom Lane 2008-11-11 03:01:20 +00:00
parent a4917bef0e
commit 3be2448525
1 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/backend/utils/mb/mbutils.c
View File

@ -4,7 +4,7 @@
* (currently mule internal code (mic) is used) * (currently mule internal code (mic) is used)
* Tatsuo Ishii * Tatsuo Ishii
* *
* $PostgreSQL: pgsql/src/backend/utils/mb/mbutils.c,v 1.74 2008/11/10 15:18:40 tgl Exp $ * $PostgreSQL: pgsql/src/backend/utils/mb/mbutils.c,v 1.75 2008/11/11 03:01:20 tgl Exp $
*/ */
#include "postgres.h" #include "postgres.h"
@ -221,8 +221,14 @@ pg_get_client_encoding_name(void)
* it's taken from pg_catalog schema. If it even is not in the schema, * it's taken from pg_catalog schema. If it even is not in the schema,
* warn and return src. * warn and return src.
* *
* If conversion occurs, a palloc'd null-terminated string is returned.
* In the case of no conversion, src is returned. * In the case of no conversion, src is returned.
* *
* CAUTION: although the presence of a length argument means that callers
* can pass non-null-terminated strings, care is required because the same
* string will be passed back if no conversion occurs. Such callers *must*
* check whether result == src and handle that case differently.
*
* Note: we try to avoid raising error, since that could get us into * Note: we try to avoid raising error, since that could get us into
* infinite recursion when this function is invoked during error message * infinite recursion when this function is invoked during error message
* sending. It should be OK to raise error for overlength strings though, * sending. It should be OK to raise error for overlength strings though,