mirrors/postgres
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix memory leak due to LogicalRepRelMapEntry.attrmap.

Browse Source 
When rebuilding the relation mapping on subscribers, we were not releasing
the attribute mapping's memory which was no longer required.

The attribute mapping used in logical tuple conversion was refactored in
PG13 (by commit e1551f96e6) but we forgot to update the related code that
frees the attribute map.

Author: Hou Zhijie
Reviewed-by: Amit Langote, Amit Kapila, Shi yu
Backpatch-through: 10, where it was introduced
Discussion: https://postgr.es/m/OSZPR01MB6310F46CD425A967E4AEF736FDA49@OSZPR01MB6310.jpnprd01.prod.outlook.com
This commit is contained in:
Amit Kapila 2022-06-23 09:02:16 +05:30
parent 9adc4cd3d6
commit 3a6ef0cdf3
1 changed files with 15 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
src/backend/replication/logical/relation.c
View File

@ -145,7 +145,7 @@ logicalrep_relmap_free_entry(LogicalRepRelMapEntry *entry)
bms_free(remoterel->attkeys); bms_free(remoterel->attkeys);
if (entry->attrmap) if (entry->attrmap)
pfree(entry->attrmap); free_attrmap(entry->attrmap);
} }
/* /*
@ -337,6 +337,13 @@ logicalrep_rel_open(LogicalRepRelId remoteid, LOCKMODE lockmode)
MemoryContext oldctx; MemoryContext oldctx;
int i; int i;
/* Release the no-longer-useful attrmap, if any. */
if (entry->attrmap)
{
free_attrmap(entry->attrmap);
entry->attrmap = NULL;
}
/* Try to find and lock the relation by name. */ /* Try to find and lock the relation by name. */
relid = RangeVarGetRelid(makeRangeVar(remoterel->nspname, relid = RangeVarGetRelid(makeRangeVar(remoterel->nspname,
remoterel->relname, -1), remoterel->relname, -1),
@ -588,6 +595,13 @@ logicalrep_partition_open(LogicalRepRelMapEntry *root,
part_entry->partoid = partOid; part_entry->partoid = partOid;
} }
/* Release the no-longer-useful attrmap, if any. */
if (entry->attrmap)
{
free_attrmap(entry->attrmap);
entry->attrmap = NULL;
}
if (!entry->remoterel.remoteid) if (!entry->remoterel.remoteid)
{ {
int i; int i;