mirrors
/
postgres
mirror of https://github.com/postgres/postgres
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Revert "Fix comments in instr_time.h and remove an unneeded cast to int64" 

This reverts commit 3dcb09de7b. Tom Lane pointed out that it broke the
abstraction provided by the macros. The callers should not need to
know what the internal type is.

This commit is an exact revert, the next commit will fix the comments
on the macros that incorrectly claim that they return uint64.

Discussion: https://www.postgresql.org/message-id/ZrHkv3MAQfwNSmTG@ip-10-97-1-34.eu-west-3.compute.internal
This commit is contained in:
Heikki Linnakangas 2024-08-06 22:15:46 +03:00
parent 6e086fa2e7
commit 39a138fbef
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/include/portability/instr_time.h
View File

@ -32,9 +32,9 @@
*
* INSTR_TIME_GET_MILLISEC(t) convert t to double (in milliseconds)
*
* INSTR_TIME_GET_MICROSEC(t) get t in microseconds
* INSTR_TIME_GET_MICROSEC(t) convert t to uint64 (in microseconds)
*
* INSTR_TIME_GET_NANOSEC(t) get t in nanoseconds
* INSTR_TIME_GET_NANOSEC(t) convert t to uint64 (in nanoseconds)
*
* Note that INSTR_TIME_SUBTRACT and INSTR_TIME_ACCUM_DIFF convert
* absolute times to intervals. The INSTR_TIME_GET_xxx operations are
@ -123,7 +123,7 @@ pg_clock_gettime_ns(void)
((t) = pg_clock_gettime_ns())
#define INSTR_TIME_GET_NANOSEC(t) \
((t).ticks)
((int64) (t).ticks)
#else /* WIN32 */