mirrors/postgres
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

int8in failed to detect overflow; it really should.

Browse Source
This commit is contained in:
Tom Lane 2000-02-24 01:54:40 +00:00
parent f40c50627f
commit 399a570fe2
1 changed files with 10 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
src/backend/utils/adt/int8.c
View File

@ -59,8 +59,7 @@ int8in(char *str)
/* /*
* Do our own scan, rather than relying on sscanf which might be * Do our own scan, rather than relying on sscanf which might be
* broken for long long. NOTE: this will not detect int64 overflow... * broken for long long.
* but sscanf doesn't either...
*/ */
while (*ptr && isspace(*ptr)) /* skip leading spaces */ while (*ptr && isspace(*ptr)) /* skip leading spaces */
ptr++; ptr++;
@ -69,11 +68,17 @@ int8in(char *str)
else if (*ptr == '+') else if (*ptr == '+')
ptr++; ptr++;
if (!isdigit(*ptr)) /* require at least one digit */ if (!isdigit(*ptr)) /* require at least one digit */
elog(ERROR, "Bad int8 external representation '%s'", str); elog(ERROR, "Bad int8 external representation \"%s\"", str);
while (*ptr && isdigit(*ptr)) /* process digits */ while (*ptr && isdigit(*ptr)) /* process digits */
tmp = tmp * 10 + (*ptr++ - '0'); {
int64 newtmp = tmp * 10 + (*ptr++ - '0');
if ((newtmp / 10) != tmp) /* overflow? */
elog(ERROR,"int8 value out of range: \"%s\"", str);
tmp = newtmp;
}
if (*ptr) /* trailing junk? */ if (*ptr) /* trailing junk? */
elog(ERROR, "Bad int8 external representation '%s'", str); elog(ERROR, "Bad int8 external representation \"%s\"", str);
*result = (sign < 0) ? -tmp : tmp; *result = (sign < 0) ? -tmp : tmp;