mirrors/postgres
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

In jsonb_plpython.c, suppress warning message from gcc 10.

Browse Source 
Very recent gcc complains that PLyObject_ToJsonbValue could return
a pointer to a local variable.  I think it's wrong; but the coding
is fragile enough, and the savings of one palloc() minimal enough,
that it seems better to just do a palloc() all the time.  (My other
idea of tweaking the if-condition doesn't suppress the warning.)

Back-patch to v11 where this code was introduced.

Discussion: https://postgr.es/m/21547.1580170366@sss.pgh.pa.us
This commit is contained in:
Tom Lane 2020-01-30 18:25:56 -05:00
parent 2c56b3ac43
commit 39428be9ce
1 changed files with 1 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
contrib/jsonb_plpython/jsonb_plpython.c
View File

@ -367,7 +367,6 @@ PLyNumber_ToJsonbValue(PyObject *obj, JsonbValue *jbvNum)
static JsonbValue * static JsonbValue *
PLyObject_ToJsonbValue(PyObject *obj, JsonbParseState **jsonb_state, bool is_elem) PLyObject_ToJsonbValue(PyObject *obj, JsonbParseState **jsonb_state, bool is_elem)
{ {
JsonbValue buf;
JsonbValue *out; JsonbValue *out;
if (!(PyString_Check(obj) || PyUnicode_Check(obj))) if (!(PyString_Check(obj) || PyUnicode_Check(obj)))
@ -378,10 +377,6 @@ PLyObject_ToJsonbValue(PyObject *obj, JsonbParseState **jsonb_state, bool is_ele
return PLyMapping_ToJsonbValue(obj, jsonb_state); return PLyMapping_ToJsonbValue(obj, jsonb_state);
} }
/* Allocate JsonbValue in heap only if it is raw scalar value. */
if (*jsonb_state)
out = &buf;
else
out = palloc(sizeof(JsonbValue)); out = palloc(sizeof(JsonbValue));
if (obj == Py_None) if (obj == Py_None)