mirrors/postgres
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Remove unused argument from ginInsertCleanup()

Browse Source 
It's an oversight in commit dc943ad.
This commit is contained in:
Fujii Masao 2016-01-22 01:22:56 +09:00
parent c80b31d557
commit 38710a374e
3 changed files with 6 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/backend/access/gin/ginfast.c
View File

@ -434,7 +434,7 @@ ginHeapTupleFastInsert(GinState *ginstate, GinTupleCollector *collector)
END_CRIT_SECTION();
if (needCleanup)
ginInsertCleanup(ginstate, false, true, NULL);
ginInsertCleanup(ginstate, true, NULL);
}
/*
@ -732,9 +732,6 @@ processPendingPage(BuildAccumulator *accum, KeyArray *ka,
* action of removing a page from the pending list really needs exclusive
* lock.
*
* vac_delay indicates that ginInsertCleanup should call
* vacuum_delay_point() periodically.
*
* fill_fsm indicates that ginInsertCleanup should add deleted pages
* to FSM otherwise caller is responsible to put deleted pages into
* FSM.
@ -743,8 +740,7 @@ processPendingPage(BuildAccumulator *accum, KeyArray *ka,
*/
void
ginInsertCleanup(GinState *ginstate,
bool vac_delay, bool fill_fsm,
IndexBulkDeleteResult *stats)
bool fill_fsm, IndexBulkDeleteResult *stats)
{
Relation index = ginstate->index;
Buffer metabuffer,

6
src/backend/access/gin/ginvacuum.c
View File

@ -541,7 +541,7 @@ ginbulkdelete(IndexVacuumInfo *info, IndexBulkDeleteResult *stats,
/* Yes, so initialize stats to zeroes */
stats = (IndexBulkDeleteResult *) palloc0(sizeof(IndexBulkDeleteResult));
/* and cleanup any pending inserts */
ginInsertCleanup(&gvs.ginstate, true, false, stats);
ginInsertCleanup(&gvs.ginstate, false, stats);
}
/* we'll re-count the tuples each time */
@ -654,7 +654,7 @@ ginvacuumcleanup(IndexVacuumInfo *info, IndexBulkDeleteResult *stats)
if (IsAutoVacuumWorkerProcess())
{
initGinState(&ginstate, index);
ginInsertCleanup(&ginstate, true, true, stats);
ginInsertCleanup(&ginstate, true, stats);
}
return stats;
}
@ -667,7 +667,7 @@ ginvacuumcleanup(IndexVacuumInfo *info, IndexBulkDeleteResult *stats)
{
stats = (IndexBulkDeleteResult *) palloc0(sizeof(IndexBulkDeleteResult));
initGinState(&ginstate, index);
ginInsertCleanup(&ginstate, true, false, stats);
ginInsertCleanup(&ginstate, false, stats);
}
memset(&idxStat, 0, sizeof(idxStat));

2
src/include/access/gin_private.h
View File

@ -946,7 +946,7 @@ extern void ginHeapTupleFastCollect(GinState *ginstate,
OffsetNumber attnum, Datum value, bool isNull,
ItemPointer ht_ctid);
extern void ginInsertCleanup(GinState *ginstate,
bool vac_delay, bool fill_fsm, IndexBulkDeleteResult *stats);
bool fill_fsm, IndexBulkDeleteResult *stats);
/* ginpostinglist.c */