mirrors/postgres
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Don't attempt to verify checksums on new pages

Browse Source 
Teach both base backups and pg_verify_checksums that if a page is new,
it does not have a checksum yet, so it shouldn't be verified.

Noted by Tomas Vondra, review by David Steele.
This commit is contained in:
Magnus Hagander 2018-04-15 14:05:56 +02:00
parent 90372729f4
commit 33cedf1474
2 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/backend/replication/basebackup.c
View File

@ -1446,8 +1446,10 @@ sendFile(const char *readfilename, const char *tarfilename, struct stat *statbuf
* written only halfway and the checksum would not be valid. * written only halfway and the checksum would not be valid.
* However, replaying WAL would reinstate the correct page in * However, replaying WAL would reinstate the correct page in
* this case. * this case.
* We also skip completely new pages, since they don't have
* a checksum yet.
*/ */
if (PageGetLSN(page) < startptr) if (!PageIsNew(page) && PageGetLSN(page) < startptr)
{ {
checksum = pg_checksum_page((char *) page, blkno + segmentno * RELSEG_SIZE); checksum = pg_checksum_page((char *) page, blkno + segmentno * RELSEG_SIZE);
phdr = (PageHeader) page; phdr = (PageHeader) page;

4
src/bin/pg_verify_checksums/pg_verify_checksums.c
View File

@ -106,6 +106,10 @@ scan_file(char *fn, int segmentno)
} }
blocks++; blocks++;
/* New pages have no checksum yet */
if (PageIsNew(buf))
continue;
csum = pg_checksum_page(buf, blockno + segmentno * RELSEG_SIZE); csum = pg_checksum_page(buf, blockno + segmentno * RELSEG_SIZE);
if (csum != header->pd_checksum) if (csum != header->pd_checksum)
{ {