mirrors/postgres
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix comment on when HOT update is possible.

Browse Source 
The conditions listed in this comment have changed several times, and at
some point the thing that the "if so" referred to was negated.

The text was OK up to 9.6. It was differently wrong in v10, v11 and
master, so fix in all those versions.
This commit is contained in:
Heikki Linnakangas 2019-05-14 13:06:33 +03:00
parent 6bbc2f9b66
commit 3293330f79
1 changed files with 4 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/backend/access/heap/heapam.c
View File

@ -4217,11 +4217,10 @@ l2:
{ {
/* /*
* Since the new tuple is going into the same page, we might be able * Since the new tuple is going into the same page, we might be able
* to do a HOT update. Check if any of the index columns have been * to do a HOT update. A HOT update is possible if none of the index
* changed, or if we have projection functional indexes, check whether * columns, nor columns used in projection functional indexes, have
* the old and the new values are the same. If the page was already * changed. If the page was already full, we may have skipped
* full, we may have skipped checking for index columns. If so, HOT * checking for index columns, and also can't do a HOT update.
* update is possible.
*/ */
if (hot_attrs_checked if (hot_attrs_checked
&& !bms_overlap(modified_attrs, hot_attrs) && !bms_overlap(modified_attrs, hot_attrs)