From 313df8f5adde186b0052d7d634a6d0ae41852de0 Mon Sep 17 00:00:00 2001 From: David Rowley Date: Mon, 12 Aug 2024 23:41:13 +1200 Subject: [PATCH] Fix outdated comments A few fields in ResultRelInfo are now also used for MERGE. Update the comments to mention that. Reported-by: jian he Discussion: https://postgr.es/m/CACJufxH8-NvFhLcSZZTTW+1M9AfS4+SOTKmyPG7ZhzNvN=+NkA@mail.gmail.com:wq --- src/include/nodes/execnodes.h | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/src/include/nodes/execnodes.h b/src/include/nodes/execnodes.h index c3670f7158..87f1519ec6 100644 --- a/src/include/nodes/execnodes.h +++ b/src/include/nodes/execnodes.h @@ -465,8 +465,8 @@ typedef struct ResultRelInfo IndexInfo **ri_IndexRelationInfo; /* - * For UPDATE/DELETE result relations, the attribute number of the row - * identity junk attribute in the source plan's output tuples + * For UPDATE/DELETE/MERGE result relations, the attribute number of the + * row identity junk attribute in the source plan's output tuples */ AttrNumber ri_RowIdAttNo; @@ -524,7 +524,9 @@ typedef struct ResultRelInfo /* array of constraint-checking expr states */ ExprState **ri_ConstraintExprs; - /* arrays of stored generated columns expr states, for INSERT and UPDATE */ + /* + * Arrays of stored generated columns ExprStates for INSERT/UPDATE/MERGE. + */ ExprState **ri_GeneratedExprsI; ExprState **ri_GeneratedExprsU;