mirrors/postgres
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Tighten the concurrent abort check during decoding.

Browse Source 
During decoding of an in-progress or prepared transaction, we detect
concurrent abort with an error code ERRCODE_TRANSACTION_ROLLBACK. That is
not sufficient because a callback can decide to throw that error code
at other times as well.

Reported-by: Tom Lane
Author: Amit Kapila
Reviewed-by: Dilip Kumar
Discussion: https://postgr.es/m/CAA4eK1KCjPRS4aZHB48QMM4J8XOC1+TD8jo-4Yu84E+MjwqVhA@mail.gmail.com
This commit is contained in:
Amit Kapila 2021-05-06 08:26:42 +05:30
parent c250062df4
commit 2ce353fc19
1 changed files with 10 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
src/backend/replication/logical/reorderbuffer.c
View File

@ -2492,17 +2492,18 @@ ReorderBufferProcessTXN(ReorderBuffer *rb, ReorderBufferTXN *txn,
* abort of the (sub)transaction we are streaming or preparing. We * abort of the (sub)transaction we are streaming or preparing. We
* need to do the cleanup and return gracefully on this error, see * need to do the cleanup and return gracefully on this error, see
* SetupCheckXidLive. * SetupCheckXidLive.
*
* This error code can be thrown by one of the callbacks we call during
* decoding so we need to ensure that we return gracefully only when we are
* sending the data in streaming mode and the streaming is not finished yet
* or when we are sending the data out on a PREPARE during a two-phase
* commit.
*/ */
if (errdata->sqlerrcode == ERRCODE_TRANSACTION_ROLLBACK) if (errdata->sqlerrcode == ERRCODE_TRANSACTION_ROLLBACK &&
(stream_started || rbtxn_prepared(txn)))
{ {
/* /* curtxn must be set for streaming or prepared transactions */
* This error can occur either when we are sending the data in Assert(curtxn);
* streaming mode and the streaming is not finished yet or when we
* are sending the data out on a PREPARE during a two-phase
* commit.
*/
Assert(streaming || rbtxn_prepared(txn));
Assert(stream_started || rbtxn_prepared(txn));
/* Cleanup the temporary error state. */ /* Cleanup the temporary error state. */
FlushErrorState(); FlushErrorState();