mirrors/postgres
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

After closing frontend socket, set MyProcPort->sock = -1 to ensure that

Browse Source 
subsequent I/O attempts fail cleanly.  I'm speculating about failure
scenarios in which we do pq_close, then something in a proc_exit routine
opens a file (re-using that kernel FD number), then something else
fails and tries to write an elog message to the frontend ... message
ends up in opened file, oops.  No known examples of this but it seems
like a potential hole.
This commit is contained in:
Tom Lane 2000-05-26 01:26:19 +00:00
parent 39725e56e8
commit 2af53f3762
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/backend/libpq/pqcomm.c
View File

@ -29,7 +29,7 @@
* Portions Copyright (c) 1996-2000, PostgreSQL, Inc
* Portions Copyright (c) 1994, Regents of the University of California
*
* $Id: pqcomm.c,v 1.91 2000/05/21 21:19:53 tgl Exp $
* $Id: pqcomm.c,v 1.92 2000/05/26 01:26:19 tgl Exp $
*
*-------------------------------------------------------------------------
*/
@ -144,7 +144,11 @@ void
pq_close(void)
{
if (MyProcPort != NULL)
{
close(MyProcPort->sock);
/* make sure any subsequent attempts to do I/O fail cleanly */
MyProcPort->sock = -1;
}
}