mirrors/postgres
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

pg_stat_statements: Add a comment about the dangers of padding bytes.

Browse Source 
Inspired by a patch from Julien Rouhaud, but I reworded it.

Discussion: http://postgr.es/m/CAOBaU_a8AH8=ypfqgHnDYu06ts+jWTUgh=VgCxA3yNV-K10j9w@mail.gmail.com
This commit is contained in:
Robert Haas 2017-10-20 09:40:17 -04:00
parent e250c8c840
commit 2959213bf3
1 changed files with 5 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
contrib/pg_stat_statements/pg_stat_statements.c
View File

@ -125,6 +125,11 @@ typedef enum pgssVersion
/* /*
* Hashtable key that defines the identity of a hashtable entry. We separate * Hashtable key that defines the identity of a hashtable entry. We separate
* queries by user and by database even if they are otherwise identical. * queries by user and by database even if they are otherwise identical.
*
* Right now, this structure contains no padding. If you add any, make sure
* to teach pgss_store() to zero the padding bytes. Otherwise, things will
* break, because pgss_hash is created using HASH_BLOBS, and thus tag_hash
* is used to hash this.
*/ */
typedef struct pgssHashKey typedef struct pgssHashKey
{ {