mirrors/postgres
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix whitespace in HashAgg EXPLAIN ANALYZE

Browse Source 
The Sort node does not put a space between the number of kilobytes and
the "kB" of memory or disk space used, but HashAgg does.  Here we align
HashAgg to do the same as Sort.  Sort has been displaying this
information for longer than HashAgg, so it makes sense to align HashAgg
to Sort rather than the other way around.

Reported-by: Justin Pryzby
Discussion: https://postgr.es/m/20200708163021.GW4107@telsasoft.com
Backpatch-through: 13, where the hashagg started showing these details
This commit is contained in:
David Rowley 2020-07-09 10:07:00 +12:00
parent a2b94693be
commit 285da44a69
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/backend/commands/explain.c
View File

@ -3099,11 +3099,11 @@ show_hashagg_info(AggState *aggstate, ExplainState *es)
else
appendStringInfoString(es->str, " ");
appendStringInfo(es->str, "Peak Memory Usage: " INT64_FORMAT " kB",
appendStringInfo(es->str, "Peak Memory Usage: " INT64_FORMAT "kB",
memPeakKb);
if (aggstate->hash_batches_used > 0)
appendStringInfo(es->str, " Disk Usage: " UINT64_FORMAT " kB HashAgg Batches: %d",
appendStringInfo(es->str, " Disk Usage: " UINT64_FORMAT "kB HashAgg Batches: %d",
aggstate->hash_disk_used,
aggstate->hash_batches_used);
appendStringInfoChar(es->str, '\n');
@ -3130,11 +3130,11 @@ show_hashagg_info(AggState *aggstate, ExplainState *es)
{
ExplainIndentText(es);
appendStringInfo(es->str, "Peak Memory Usage: " INT64_FORMAT " kB",
appendStringInfo(es->str, "Peak Memory Usage: " INT64_FORMAT "kB",
memPeakKb);
if (hash_batches_used > 0)
appendStringInfo(es->str, " Disk Usage: " UINT64_FORMAT " kB HashAgg Batches: %d",
appendStringInfo(es->str, " Disk Usage: " UINT64_FORMAT "kB HashAgg Batches: %d",
hash_disk_used, hash_batches_used);
appendStringInfoChar(es->str, '\n');
}