mirrors/postgres
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix entirely broken permissions test in new alter_operator regression test.

Browse Source 
Not only did this test fail to test what it was supposed to test, but it
left a user definition lying around, which caused subsequent runs of the
regression tests to fail.
This commit is contained in:
Tom Lane 2015-07-17 14:10:52 -04:00
parent a04bb65f70
commit 266e771435
2 changed files with 7 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/test/regress/expected/alter_operator.out
View File

@ -66,11 +66,10 @@ ERROR: operator attribute "negator" can not be changed
-- Test permission check. Must be owner to ALTER OPERATOR.
--
CREATE USER regtest_alter_user;
SET SESSION AUTHORIZATION regtest_alter_user_user;
ERROR: role "regtest_alter_user_user" does not exist
SET SESSION AUTHORIZATION regtest_alter_user;
ALTER OPERATOR === (boolean, boolean) SET (RESTRICT = NONE);
RESET SESSION AUTHORIZATION;
ERROR: must be owner of operator ===
-- Clean up
DROP USER regression_alter_user;
ERROR: role "regression_alter_user" does not exist
RESET SESSION AUTHORIZATION;
DROP USER regtest_alter_user;
DROP OPERATOR === (boolean, boolean);

8
src/test/regress/sql/alter_operator.sql
View File

@ -48,17 +48,15 @@ ALTER OPERATOR === (boolean, boolean) SET (JOIN = non_existent_func);
ALTER OPERATOR === (boolean, boolean) SET (COMMUTATOR = !==);
ALTER OPERATOR === (boolean, boolean) SET (NEGATOR = !==);
--
-- Test permission check. Must be owner to ALTER OPERATOR.
--
CREATE USER regtest_alter_user;
SET SESSION AUTHORIZATION regtest_alter_user_user;
SET SESSION AUTHORIZATION regtest_alter_user;
ALTER OPERATOR === (boolean, boolean) SET (RESTRICT = NONE);
RESET SESSION AUTHORIZATION;
-- Clean up
DROP USER regression_alter_user;
RESET SESSION AUTHORIZATION;
DROP USER regtest_alter_user;
DROP OPERATOR === (boolean, boolean);