mirrors/postgres
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

simplehash: Free collisions array in SH_STAT

Browse Source 
While SH_STAT() is only used for debugging, the allocated array can be large,
and therefore should be freed.

It's unclear why coverity started warning now.

Reported-by: Tom Lane <tgl@sss.pgh.pa.us>
Reported-by: Coverity
Discussion: https://postgr.es/m/3005248.1712538233@sss.pgh.pa.us
Backpatch: 12-
This commit is contained in:
Andres Freund 2024-04-07 19:00:11 -07:00
parent 7a05413010
commit 25ee58e8f2
1 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/include/lib/simplehash.h
View File

@ -1102,6 +1102,9 @@ SH_STAT(SH_TYPE * tb)
max_collisions = curcoll; max_collisions = curcoll;
} }
/* large enough to be worth freeing, even if just used for debugging */
pfree(collisions);
if (tb->members > 0) if (tb->members > 0)
{ {
fillfactor = tb->members / ((double) tb->size); fillfactor = tb->members / ((double) tb->size);