Fix make installcheck
for serializable transactions.
Commit e5550d5fec66aa74caad1f79b79826ec64898688 added some new tests for ALTER TABLE which involved table scans. When default_transaction_isolation = 'serializable' these acquire relation-level SIReadLocks. The test results didn't cope with that. Add SIReadLock as the minimum lock level for purposes of these tests. This could also be fixed by excluding this type of lock from the my_locks view, but it would be a bug for SIReadLock to show up for a relation which was not otherwise locked, so do it this way to allow that sort of condition to cause a regression test failure. There is some question whether we could avoid taking SIReadLocks during these operations, but confirming the safety of that and figuring out how to avoid the locks is not trivial, and would be a separate patch. Backpatch to 9.4 where the new tests were added.
This commit is contained in:
parent
3a145757a0
commit
253de7e1eb
@ -1842,7 +1842,8 @@ DROP TABLE check_fk_presence_1, check_fk_presence_2;
|
|||||||
drop type lockmodes;
|
drop type lockmodes;
|
||||||
ERROR: type "lockmodes" does not exist
|
ERROR: type "lockmodes" does not exist
|
||||||
create type lockmodes as enum (
|
create type lockmodes as enum (
|
||||||
'AccessShareLock'
|
'SIReadLock'
|
||||||
|
,'AccessShareLock'
|
||||||
,'RowShareLock'
|
,'RowShareLock'
|
||||||
,'RowExclusiveLock'
|
,'RowExclusiveLock'
|
||||||
,'ShareUpdateExclusiveLock'
|
,'ShareUpdateExclusiveLock'
|
||||||
|
@ -1271,7 +1271,8 @@ DROP TABLE check_fk_presence_1, check_fk_presence_2;
|
|||||||
--
|
--
|
||||||
drop type lockmodes;
|
drop type lockmodes;
|
||||||
create type lockmodes as enum (
|
create type lockmodes as enum (
|
||||||
'AccessShareLock'
|
'SIReadLock'
|
||||||
|
,'AccessShareLock'
|
||||||
,'RowShareLock'
|
,'RowShareLock'
|
||||||
,'RowExclusiveLock'
|
,'RowExclusiveLock'
|
||||||
,'ShareUpdateExclusiveLock'
|
,'ShareUpdateExclusiveLock'
|
||||||
|
Loading…
x
Reference in New Issue
Block a user