From 244dd95ce9d9831f8498f5746860325f7adcecbf Mon Sep 17 00:00:00 2001 From: Tom Lane Date: Sun, 26 Mar 2017 11:36:46 -0400 Subject: [PATCH] Update some obsolete comments. Fix a few stray references to expression eval functions that don't exist anymore or don't take the same input representation they used to. --- src/backend/optimizer/util/clauses.c | 4 ++-- src/backend/utils/cache/relcache.c | 2 +- src/pl/plpgsql/src/pl_exec.c | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/backend/optimizer/util/clauses.c b/src/backend/optimizer/util/clauses.c index 42bba543e9..a578867cce 100644 --- a/src/backend/optimizer/util/clauses.c +++ b/src/backend/optimizer/util/clauses.c @@ -354,8 +354,8 @@ make_and_qual(Node *qual1, Node *qual2) } /* - * Sometimes (such as in the input of ExecQual), we use lists of expression - * nodes with implicit AND semantics. + * The planner frequently prefers to represent qualification expressions + * as lists of boolean expressions with implicit AND semantics. * * These functions convert between an AND-semantics expression list and the * ordinary representation of a boolean expression. diff --git a/src/backend/utils/cache/relcache.c b/src/backend/utils/cache/relcache.c index a6b60c67ca..bc52183bfb 100644 --- a/src/backend/utils/cache/relcache.c +++ b/src/backend/utils/cache/relcache.c @@ -4743,7 +4743,7 @@ RelationGetIndexExpressions(Relation relation) * RelationGetIndexPredicate -- get the index predicate for an index * * We cache the result of transforming pg_index.indpred into an implicit-AND - * node tree (suitable for ExecQual). + * node tree (suitable for use in planning). * If the rel is not an index or has no predicate, we return NIL. * Otherwise, the returned tree is copied into the caller's memory context. * (We don't want to return a pointer to the relcache copy, since it could diff --git a/src/pl/plpgsql/src/pl_exec.c b/src/pl/plpgsql/src/pl_exec.c index 84af815537..c27935b51b 100644 --- a/src/pl/plpgsql/src/pl_exec.c +++ b/src/pl/plpgsql/src/pl_exec.c @@ -4759,7 +4759,7 @@ exec_assign_value(PLpgSQL_execstate *estate, * fixed-length array types we skip the assignment. We can't * support assignment of a null entry into a fixed-length * array, either, so that's a no-op too. This is all ugly but - * corresponds to the current behavior of ExecEvalArrayRef(). + * corresponds to the current behavior of execExpr*.c. */ if (arrayelem->arraytyplen > 0 && /* fixed-length array? */ (oldarrayisnull || isNull))