mirrors/postgres
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

More code cleanup for configurable TOAST compression.

Browse Source 
Remove unused macro. Fix confusion about whether a TOAST compression
method is identified by an OID or a char.

Justin Pryzby

Discussion: http://postgr.es/m/20210321235544.GD4203@telsasoft.com
This commit is contained in:
Robert Haas 2021-03-22 09:21:37 -04:00
parent 909b449e00
commit 226e2be387
2 changed files with 5 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/backend/commands/tablecmds.c
View File

@ -7847,6 +7847,7 @@ SetIndexStorageProperties(Relation rel, Relation attrelation,
index_close(indrel, lockmode); index_close(indrel, lockmode);
} }
} }
/* /*
* ALTER TABLE ALTER COLUMN SET STORAGE * ALTER TABLE ALTER COLUMN SET STORAGE
* *
@ -15070,7 +15071,7 @@ ATExecSetCompression(AlteredTableInfo *tab,
AttrNumber attnum; AttrNumber attnum;
char *compression; char *compression;
char typstorage; char typstorage;
Oid cmoid; char cmethod;
ObjectAddress address; ObjectAddress address;
Assert(IsA(newValue, String)); Assert(IsA(newValue, String));
@ -15104,10 +15105,10 @@ ATExecSetCompression(AlteredTableInfo *tab,
format_type_be(atttableform->atttypid)))); format_type_be(atttableform->atttypid))));
/* get the attribute compression method. */ /* get the attribute compression method. */
cmoid = GetAttributeCompression(atttableform, compression); cmethod = GetAttributeCompression(atttableform, compression);
/* update pg_attribute entry */ /* update pg_attribute entry */
atttableform->attcompression = cmoid; atttableform->attcompression = cmethod;
CatalogTupleUpdate(attrel, &tuple->t_self, tuple); CatalogTupleUpdate(attrel, &tuple->t_self, tuple);
InvokeObjectPostAlterHook(RelationRelationId, InvokeObjectPostAlterHook(RelationRelationId,
@ -15118,7 +15119,7 @@ ATExecSetCompression(AlteredTableInfo *tab,
* Apply the change to indexes as well (only for simple index columns, * Apply the change to indexes as well (only for simple index columns,
* matching behavior of index.c ConstructTupleDescriptor()). * matching behavior of index.c ConstructTupleDescriptor()).
*/ */
SetIndexStorageProperties(rel, attrel, attnum, cmoid, '\0', lockmode); SetIndexStorageProperties(rel, attrel, attnum, cmethod, '\0', lockmode);
heap_freetuple(tuple); heap_freetuple(tuple);

2
src/include/access/toast_compression.h
View File

@ -50,8 +50,6 @@ typedef enum ToastCompressionId
errdetail("This functionality requires the server to be built with lz4 support."), \ errdetail("This functionality requires the server to be built with lz4 support."), \
errhint("You need to rebuild PostgreSQL using --with-lz4."))) errhint("You need to rebuild PostgreSQL using --with-lz4.")))
#define IsValidCompression(cm) ((cm) != InvalidCompressionMethod)
#define IsStorageCompressible(storage) ((storage) != TYPSTORAGE_PLAIN && \ #define IsStorageCompressible(storage) ((storage) != TYPSTORAGE_PLAIN && \
(storage) != TYPSTORAGE_EXTERNAL) (storage) != TYPSTORAGE_EXTERNAL)