From 1e6e40447115ca7b4749d7d117b81b016ee5e2c2 Mon Sep 17 00:00:00 2001 From: Andres Freund Date: Mon, 1 Mar 2021 09:52:15 -0800 Subject: [PATCH] Fix recovery test hang in 021_row_visibility.pl on windows. The psql processes were not explicitly killed (but would eventually exit due postgres shutting down). For some reason windows perl doesn't like that, resulting in errors like Warning: unable to close filehandle GEN20 properly: Bad file descriptor during global destruction. The test was introduced in d6734a897e3, so no backpatching necessary. --- src/test/recovery/t/021_row_visibility.pl | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/test/recovery/t/021_row_visibility.pl b/src/test/recovery/t/021_row_visibility.pl index fac6646a87..b76990dfe0 100644 --- a/src/test/recovery/t/021_row_visibility.pl +++ b/src/test/recovery/t/021_row_visibility.pl @@ -151,6 +151,10 @@ ok(send_query_and_wait(\%psql_standby, qr/will_commit.*\n\(1 row\)$/m), 'finished prepared visible'); +# explicitly shut down psql instances - they cause hangs on windows +$psql_primary{run}->kill_kill; +$psql_standby{run}->kill_kill; + $node_primary->stop; $node_standby->stop;