mirrors/postgres
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Don't use !! but != 0/NULL to force boolean evaluation.

Browse Source 
I introduced several uses of !! to force bit arithmetic to be boolean,
but per discussion the project prefers != 0/NULL.

Discussion: CA+TgmoZP5KakLGP6B4vUjgMBUW0woq_dJYi0paOz-My0Hwt_vQ@mail.gmail.com
This commit is contained in:
Andres Freund 2016-03-27 17:17:00 +02:00
parent af4472bcb8
commit 1a7a43672b
5 changed files with 12 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
contrib/sepgsql/uavc.c
View File

@ -407,7 +407,7 @@ sepgsql_avc_check_perms_label(const char *tcontext,
audit_name != SEPGSQL_AVC_NOAUDIT && audit_name != SEPGSQL_AVC_NOAUDIT &&
sepgsql_get_mode() != SEPGSQL_MODE_INTERNAL) sepgsql_get_mode() != SEPGSQL_MODE_INTERNAL)
{ {
sepgsql_audit_log(!!denied, sepgsql_audit_log(denied != 0,
cache->scontext, cache->scontext,
cache->tcontext_is_valid ? cache->tcontext_is_valid ?
cache->tcontext : sepgsql_avc_unlabeled(), cache->tcontext : sepgsql_avc_unlabeled(),

3
src/backend/access/transam/xact.c
View File

@ -5335,7 +5335,8 @@ xact_redo_commit(xl_xact_parsed_commit *parsed,
LWLockRelease(XidGenLock); LWLockRelease(XidGenLock);
} }
Assert(!!(parsed->xinfo & XACT_XINFO_HAS_ORIGIN) == (origin_id != InvalidRepOriginId)); Assert(((parsed->xinfo & XACT_XINFO_HAS_ORIGIN) == 0) ==
(origin_id == InvalidRepOriginId));
if (parsed->xinfo & XACT_XINFO_HAS_ORIGIN) if (parsed->xinfo & XACT_XINFO_HAS_ORIGIN)
commit_time = parsed->origin_timestamp; commit_time = parsed->origin_timestamp;

2
src/backend/replication/logical/reorderbuffer.c
View File

@ -603,7 +603,7 @@ ReorderBufferTXNByXid(ReorderBuffer *rb, TransactionId xid, bool create,
if (is_new) if (is_new)
*is_new = !found; *is_new = !found;
Assert(!create || !!txn); Assert(!create || txn != NULL);
return txn; return txn;
} }

12
src/backend/storage/lmgr/lwlock.c
View File

@ -209,11 +209,11 @@ PRINT_LWDEBUG(const char *where, LWLock *lock, LWLockMode mode)
errmsg_internal("%d: %s(%s): excl %u shared %u haswaiters %u waiters %u rOK %d", errmsg_internal("%d: %s(%s): excl %u shared %u haswaiters %u waiters %u rOK %d",
MyProcPid, MyProcPid,
where, MainLWLockNames[id], where, MainLWLockNames[id],
!!(state & LW_VAL_EXCLUSIVE), (state & LW_VAL_EXCLUSIVE) != 0,
state & LW_SHARED_MASK, state & LW_SHARED_MASK,
!!(state & LW_FLAG_HAS_WAITERS), (state & LW_FLAG_HAS_WAITERS) != 0,
pg_atomic_read_u32(&lock->nwaiters), pg_atomic_read_u32(&lock->nwaiters),
!!(state & LW_FLAG_RELEASE_OK)))); (state & LW_FLAG_RELEASE_OK) != 0)));
else else
ereport(LOG, ereport(LOG,
(errhidestmt(true), (errhidestmt(true),
@ -221,11 +221,11 @@ PRINT_LWDEBUG(const char *where, LWLock *lock, LWLockMode mode)
errmsg_internal("%d: %s(%s %d): excl %u shared %u haswaiters %u waiters %u rOK %d", errmsg_internal("%d: %s(%s %d): excl %u shared %u haswaiters %u waiters %u rOK %d",
MyProcPid, MyProcPid,
where, T_NAME(lock), id, where, T_NAME(lock), id,
!!(state & LW_VAL_EXCLUSIVE), (state & LW_VAL_EXCLUSIVE) != 0,
state & LW_SHARED_MASK, state & LW_SHARED_MASK,
!!(state & LW_FLAG_HAS_WAITERS), (state & LW_FLAG_HAS_WAITERS) != 0,
pg_atomic_read_u32(&lock->nwaiters), pg_atomic_read_u32(&lock->nwaiters),
!!(state & LW_FLAG_RELEASE_OK)))); (state & LW_FLAG_RELEASE_OK) != 0)));
} }
} }

4
src/include/access/xact.h
View File

@ -149,9 +149,9 @@ typedef void (*SubXactCallback) (SubXactEvent event, SubTransactionId mySubid,
/* Access macros for above flags */ /* Access macros for above flags */
#define XactCompletionRelcacheInitFileInval(xinfo) \ #define XactCompletionRelcacheInitFileInval(xinfo) \
(!!(xinfo & XACT_COMPLETION_UPDATE_RELCACHE_FILE)) ((xinfo & XACT_COMPLETION_UPDATE_RELCACHE_FILE) != 0)
#define XactCompletionForceSyncCommit(xinfo) \ #define XactCompletionForceSyncCommit(xinfo) \
(!!(xinfo & XACT_COMPLETION_FORCE_SYNC_COMMIT)) ((xinfo & XACT_COMPLETION_FORCE_SYNC_COMMIT) != 0)
typedef struct xl_xact_assignment typedef struct xl_xact_assignment
{ {