Don't use !! but != 0/NULL to force boolean evaluation.
I introduced several uses of !! to force bit arithmetic to be boolean, but per discussion the project prefers != 0/NULL. Discussion: CA+TgmoZP5KakLGP6B4vUjgMBUW0woq_dJYi0paOz-My0Hwt_vQ@mail.gmail.com
This commit is contained in:
parent
af4472bcb8
commit
1a7a43672b
@ -407,7 +407,7 @@ sepgsql_avc_check_perms_label(const char *tcontext,
|
||||
audit_name != SEPGSQL_AVC_NOAUDIT &&
|
||||
sepgsql_get_mode() != SEPGSQL_MODE_INTERNAL)
|
||||
{
|
||||
sepgsql_audit_log(!!denied,
|
||||
sepgsql_audit_log(denied != 0,
|
||||
cache->scontext,
|
||||
cache->tcontext_is_valid ?
|
||||
cache->tcontext : sepgsql_avc_unlabeled(),
|
||||
|
@ -5335,7 +5335,8 @@ xact_redo_commit(xl_xact_parsed_commit *parsed,
|
||||
LWLockRelease(XidGenLock);
|
||||
}
|
||||
|
||||
Assert(!!(parsed->xinfo & XACT_XINFO_HAS_ORIGIN) == (origin_id != InvalidRepOriginId));
|
||||
Assert(((parsed->xinfo & XACT_XINFO_HAS_ORIGIN) == 0) ==
|
||||
(origin_id == InvalidRepOriginId));
|
||||
|
||||
if (parsed->xinfo & XACT_XINFO_HAS_ORIGIN)
|
||||
commit_time = parsed->origin_timestamp;
|
||||
|
@ -603,7 +603,7 @@ ReorderBufferTXNByXid(ReorderBuffer *rb, TransactionId xid, bool create,
|
||||
if (is_new)
|
||||
*is_new = !found;
|
||||
|
||||
Assert(!create || !!txn);
|
||||
Assert(!create || txn != NULL);
|
||||
return txn;
|
||||
}
|
||||
|
||||
|
@ -209,11 +209,11 @@ PRINT_LWDEBUG(const char *where, LWLock *lock, LWLockMode mode)
|
||||
errmsg_internal("%d: %s(%s): excl %u shared %u haswaiters %u waiters %u rOK %d",
|
||||
MyProcPid,
|
||||
where, MainLWLockNames[id],
|
||||
!!(state & LW_VAL_EXCLUSIVE),
|
||||
(state & LW_VAL_EXCLUSIVE) != 0,
|
||||
state & LW_SHARED_MASK,
|
||||
!!(state & LW_FLAG_HAS_WAITERS),
|
||||
(state & LW_FLAG_HAS_WAITERS) != 0,
|
||||
pg_atomic_read_u32(&lock->nwaiters),
|
||||
!!(state & LW_FLAG_RELEASE_OK))));
|
||||
(state & LW_FLAG_RELEASE_OK) != 0)));
|
||||
else
|
||||
ereport(LOG,
|
||||
(errhidestmt(true),
|
||||
@ -221,11 +221,11 @@ PRINT_LWDEBUG(const char *where, LWLock *lock, LWLockMode mode)
|
||||
errmsg_internal("%d: %s(%s %d): excl %u shared %u haswaiters %u waiters %u rOK %d",
|
||||
MyProcPid,
|
||||
where, T_NAME(lock), id,
|
||||
!!(state & LW_VAL_EXCLUSIVE),
|
||||
(state & LW_VAL_EXCLUSIVE) != 0,
|
||||
state & LW_SHARED_MASK,
|
||||
!!(state & LW_FLAG_HAS_WAITERS),
|
||||
(state & LW_FLAG_HAS_WAITERS) != 0,
|
||||
pg_atomic_read_u32(&lock->nwaiters),
|
||||
!!(state & LW_FLAG_RELEASE_OK))));
|
||||
(state & LW_FLAG_RELEASE_OK) != 0)));
|
||||
}
|
||||
}
|
||||
|
||||
|
@ -149,9 +149,9 @@ typedef void (*SubXactCallback) (SubXactEvent event, SubTransactionId mySubid,
|
||||
|
||||
/* Access macros for above flags */
|
||||
#define XactCompletionRelcacheInitFileInval(xinfo) \
|
||||
(!!(xinfo & XACT_COMPLETION_UPDATE_RELCACHE_FILE))
|
||||
((xinfo & XACT_COMPLETION_UPDATE_RELCACHE_FILE) != 0)
|
||||
#define XactCompletionForceSyncCommit(xinfo) \
|
||||
(!!(xinfo & XACT_COMPLETION_FORCE_SYNC_COMMIT))
|
||||
((xinfo & XACT_COMPLETION_FORCE_SYNC_COMMIT) != 0)
|
||||
|
||||
typedef struct xl_xact_assignment
|
||||
{
|
||||
|
Loading…
x
Reference in New Issue
Block a user