mirrors/postgres
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

If pk is NULL, the backend would segfault when accessing ->algo and the

Browse Source 
following NULL check was never reached.

This problem was found by Coccinelle (null_ref.cocci from coccicheck).

Marti Raudsepp
This commit is contained in:
Heikki Linnakangas 2010-10-20 22:20:33 +03:00
parent def30e84c4
commit 18e752f226
1 changed files with 3 additions and 1 deletions

4
contrib/pgcrypto/pgp-pubenc.c

@ -199,7 +199,7 @@ pgp_write_pubenc_sesskey(PGP_Context *ctx, PushFilter *dst)
PGP_PubKey *pk = ctx->pub_key; PGP_PubKey *pk = ctx->pub_key;
uint8 ver = 3; uint8 ver = 3;
PushFilter *pkt = NULL; PushFilter *pkt = NULL;
uint8 algo = pk->algo; uint8 algo;
if (pk == NULL) if (pk == NULL)
{ {
@ -207,6 +207,8 @@ pgp_write_pubenc_sesskey(PGP_Context *ctx, PushFilter *dst)
return PXE_BUG; return PXE_BUG;
} }
algo = pk->algo;
/* /*
* now write packet * now write packet
*/ */