mirrors/postgres
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Improve error messages around REPLICATION and BYPASSRLS properties.

Browse Source 
Clarify wording as per suggestion from Wolfgang Walther.
No back-patch; this doesn't seem worth thrashing translatable
strings in the back branches.

Tom Lane and Stephen Frost

Discussion: https://postgr.es/m/a5548a9f-89ee-3167-129d-162b5985fcf8@technowledgy.de
This commit is contained in:
Tom Lane 2020-11-03 15:49:05 -05:00
parent d907bd0543
commit 17fb60387c
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/backend/commands/user.c
View File

@ -305,7 +305,7 @@ CreateRole(ParseState *pstate, CreateRoleStmt *stmt)
if (!superuser()) if (!superuser())
ereport(ERROR, ereport(ERROR,
(errcode(ERRCODE_INSUFFICIENT_PRIVILEGE), (errcode(ERRCODE_INSUFFICIENT_PRIVILEGE),
errmsg("must be superuser to change bypassrls attribute"))); errmsg("must be superuser to create bypassrls users")));
} }
else else
{ {
@ -719,14 +719,14 @@ AlterRole(AlterRoleStmt *stmt)
if (!superuser()) if (!superuser())
ereport(ERROR, ereport(ERROR,
(errcode(ERRCODE_INSUFFICIENT_PRIVILEGE), (errcode(ERRCODE_INSUFFICIENT_PRIVILEGE),
errmsg("must be superuser to alter superusers"))); errmsg("must be superuser to alter superuser roles or change superuser attribute")));
} }
else if (authform->rolreplication || isreplication >= 0) else if (authform->rolreplication || isreplication >= 0)
{ {
if (!superuser()) if (!superuser())
ereport(ERROR, ereport(ERROR,
(errcode(ERRCODE_INSUFFICIENT_PRIVILEGE), (errcode(ERRCODE_INSUFFICIENT_PRIVILEGE),
errmsg("must be superuser to alter replication users"))); errmsg("must be superuser to alter replication roles or change replication attribute")));
} }
else if (bypassrls >= 0) else if (bypassrls >= 0)
{ {