mirrors/postgres
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Suppress Coverity warnings about Asserts in get_name_for_var_field.

Browse Source 
Coverity thinks dpns->plan could be null at these points.  That
shouldn't really be possible, but it's easy enough to modify the
Asserts so they'd not core-dump if it were true.

These are new in b919a97a6.  Back-patch to v13; the v12 version
of the patch didn't have these Asserts.
This commit is contained in:
Tom Lane 2024-08-11 12:24:56 -04:00
parent 2f4e895be7
commit 16e67bc5f9
1 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/backend/utils/adt/ruleutils.c
View File

@ -7897,11 +7897,11 @@ get_name_for_var_field(Var *var, int fieldno,
{ {
char *dummy_name = palloc(32); char *dummy_name = palloc(32);
Assert(IsA(dpns->plan, Result)); Assert(dpns->plan && IsA(dpns->plan, Result));
snprintf(dummy_name, 32, "f%d", fieldno); snprintf(dummy_name, 32, "f%d", fieldno);
return dummy_name; return dummy_name;
} }
Assert(IsA(dpns->plan, SubqueryScan)); Assert(dpns->plan && IsA(dpns->plan, SubqueryScan));
tle = get_tle_by_resno(dpns->inner_tlist, attnum); tle = get_tle_by_resno(dpns->inner_tlist, attnum);
if (!tle) if (!tle)
@ -8028,12 +8028,12 @@ get_name_for_var_field(Var *var, int fieldno,
{ {
char *dummy_name = palloc(32); char *dummy_name = palloc(32);
Assert(IsA(dpns->plan, Result)); Assert(dpns->plan && IsA(dpns->plan, Result));
snprintf(dummy_name, 32, "f%d", fieldno); snprintf(dummy_name, 32, "f%d", fieldno);
return dummy_name; return dummy_name;
} }
Assert(IsA(dpns->plan, CteScan) || Assert(dpns->plan && (IsA(dpns->plan, CteScan) ||
IsA(dpns->plan, WorkTableScan)); IsA(dpns->plan, WorkTableScan)));
tle = get_tle_by_resno(dpns->inner_tlist, attnum); tle = get_tle_by_resno(dpns->inner_tlist, attnum);
if (!tle) if (!tle)