mirrors/postgres
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Remove useless Asserts in Result Cache code

Browse Source 
Testing if an unsigned variable is >= 0 is pretty pointless.

There's likely enough code in remove_cache_entry() to verify the cache
memory accounting is correct in assert enabled builds. These Asserts
were not adding much extra cover, even if they had been checking >= 0 on a
signed variable.

Reported-by: Andres Freund
Discussion: https://postgr.es/m/20210402204734.6mo3nfacnljlicgn@alap3.anarazel.de
This commit is contained in:
David Rowley 2021-04-03 10:41:43 +13:00
parent 84bc2b1752
commit 1267d9862f
1 changed files with 0 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/backend/executor/nodeResultCache.c
View File

@ -286,8 +286,6 @@ entry_purge_tuples(ResultCacheState *rcstate, ResultCacheEntry *entry)
/* Update the memory accounting */ /* Update the memory accounting */
rcstate->mem_used -= freed_mem; rcstate->mem_used -= freed_mem;
Assert(rcstate->mem_used >= 0);
} }
/* /*
@ -346,8 +344,6 @@ remove_cache_entry(ResultCacheState *rcstate, ResultCacheEntry *entry)
*/ */
rcstate->mem_used -= EMPTY_ENTRY_MEMORY_BYTES(entry); rcstate->mem_used -= EMPTY_ENTRY_MEMORY_BYTES(entry);
Assert(rcstate->mem_used >= 0);
/* Remove the entry from the cache */ /* Remove the entry from the cache */
resultcache_delete_item(rcstate->hashtable, entry); resultcache_delete_item(rcstate->hashtable, entry);