mirrors/postgres
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

logical decoding: Remove TODO about unnecessary optimization.

Browse Source 
Measurements show, and intuition agrees, that there's currently no
known cases where adding a fastpath to avoid allocating / ordering a
heap for a single transaction is worthwhile.

Author: Dilip Kumar
Discussion: https://postgr.es/m/CAFiTN-sp701wvzvnLQJGk7JDqrFM8f--97-ihbwkU8qvn=p8nw@mail.gmail.com
This commit is contained in:
Andres Freund 2020-03-24 12:14:18 -07:00
parent f15ace7935
commit 112b006fe7
1 changed files with 0 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/backend/replication/logical/reorderbuffer.c
View File

@ -1037,11 +1037,6 @@ ReorderBufferIterTXNInit(ReorderBuffer *rb, ReorderBufferTXN *txn,
nr_txns++; nr_txns++;
} }
/*
* TODO: Consider adding fastpath for the rather common nr_txns=1 case, no
* need to allocate/build a heap then.
*/
/* allocate iteration state */ /* allocate iteration state */
state = (ReorderBufferIterTXNState *) state = (ReorderBufferIterTXNState *)
MemoryContextAllocZero(rb->context, MemoryContextAllocZero(rb->context,