mirrors/postgres
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix comment about ressortgrouprefs being unique in setop plans.

Browse Source 
Author: Richard Guo, Tom Lane
Discussion: https://www.postgresql.org/message-id/CAMbWs49rAfFS-yd7=QxtDUrZDFfRBGy4rGBJNyGDH7=CLipFPg@mail.gmail.com
This commit is contained in:
Heikki Linnakangas 2023-11-28 14:08:43 +02:00
parent f36b63623d
commit 10a59925a3
1 changed files with 8 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/backend/optimizer/plan/setrefs.c
View File

@ -2936,7 +2936,14 @@ search_indexed_tlist_for_sortgroupref(Expr *node,
{ {
TargetEntry *tle = (TargetEntry *) lfirst(lc); TargetEntry *tle = (TargetEntry *) lfirst(lc);
/* The equal() check should be redundant, but let's be paranoid */ /*
* Usually the equal() check is redundant, but in setop plans it may
* not be, since prepunion.c assigns ressortgroupref equal to the
* column resno without regard to whether that matches the topmost
* level's sortgrouprefs and without regard to whether any implicit
* coercions are added in the setop tree. We might have to clean that
* up someday; but for now, just ignore any false matches.
*/
if (tle->ressortgroupref == sortgroupref && if (tle->ressortgroupref == sortgroupref &&
equal(node, tle->expr)) equal(node, tle->expr))
{ {