mirrors/postgres
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

ExecRestrPos() really needs to raise ERROR, not a wimpy DEBUG message,

Browse Source 
if given a node type it doesn't support.  As is, wrong results from a
mergejoin would go undetected.
This commit is contained in:
Tom Lane 2000-07-25 23:43:38 +00:00
parent 742cd87999
commit 0e06e68387
1 changed files with 18 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

29
src/backend/executor/execAmi.c
View File

@ -6,7 +6,7 @@
* Portions Copyright (c) 1996-2000, PostgreSQL, Inc * Portions Copyright (c) 1996-2000, PostgreSQL, Inc
* Portions Copyright (c) 1994, Regents of the University of California * Portions Copyright (c) 1994, Regents of the University of California
* *
* $Id: execAmi.c,v 1.49 2000/07/12 02:37:00 tgl Exp $ * $Id: execAmi.c,v 1.50 2000/07/25 23:43:38 tgl Exp $
* *
*------------------------------------------------------------------------- *-------------------------------------------------------------------------
*/ */
@ -356,7 +356,8 @@ ExecReScan(Plan *node, ExprContext *exprCtxt, Plan *parent)
break; break;
default: default:
elog(ERROR, "ExecReScan: node type %u not supported", nodeTag(node)); elog(ERROR, "ExecReScan: node type %d not supported",
nodeTag(node));
return; return;
} }
@ -393,7 +394,8 @@ ExecReScanR(Relation relDesc, /* LLL relDesc unused */
* *
* Marks the current scan position. * Marks the current scan position.
* *
* XXX Needs to be extended to include all the node types. * XXX Needs to be extended to include all the node types,
* or at least all the ones that can be directly below a mergejoin.
* ---------------------------------------------------------------- * ----------------------------------------------------------------
*/ */
void void
@ -422,16 +424,20 @@ ExecMarkPos(Plan *node)
break; break;
default: default:
elog(DEBUG, "ExecMarkPos: node type %u not supported", nodeTag(node)); /* don't make hard error unless caller asks to restore... */
elog(DEBUG, "ExecMarkPos: node type %d not supported",
nodeTag(node));
break; break;
} }
return;
} }
/* ---------------------------------------------------------------- /* ----------------------------------------------------------------
* ExecRestrPos * ExecRestrPos
* *
* restores the scan position previously saved with ExecMarkPos() * restores the scan position previously saved with ExecMarkPos()
*
* XXX Needs to be extended to include all the node types,
* or at least all the ones that can be directly below a mergejoin.
* ---------------------------------------------------------------- * ----------------------------------------------------------------
*/ */
void void
@ -441,22 +447,23 @@ ExecRestrPos(Plan *node)
{ {
case T_SeqScan: case T_SeqScan:
ExecSeqRestrPos((SeqScan *) node); ExecSeqRestrPos((SeqScan *) node);
return; break;
case T_IndexScan: case T_IndexScan:
ExecIndexRestrPos((IndexScan *) node); ExecIndexRestrPos((IndexScan *) node);
return; break;
case T_Material: case T_Material:
ExecMaterialRestrPos((Material *) node); ExecMaterialRestrPos((Material *) node);
return; break;
case T_Sort: case T_Sort:
ExecSortRestrPos((Sort *) node); ExecSortRestrPos((Sort *) node);
return; break;
default: default:
elog(DEBUG, "ExecRestrPos: node type %u not supported", nodeTag(node)); elog(ERROR, "ExecRestrPos: node type %d not supported",
return; nodeTag(node));
break;
} }
} }