mirrors/postgres
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Always schema-qualify the name of a function referenced in CREATE CAST.

Browse Source 
The former coding failed if the cast function was not in the pg_catalog
schema.  How'd this escape detection?
This commit is contained in:
Tom Lane 2004-03-02 21:14:44 +00:00
parent 351cf4d04e
commit 0c6e97db47
1 changed files with 10 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
src/bin/pg_dump/pg_dump.c
View File

@ -12,7 +12,7 @@
* by PostgreSQL
*
* IDENTIFICATION
* $PostgreSQL: pgsql/src/bin/pg_dump/pg_dump.c,v 1.365 2004/02/24 03:35:19 tgl Exp $
* $PostgreSQL: pgsql/src/bin/pg_dump/pg_dump.c,v 1.366 2004/03/02 21:14:44 tgl Exp $
*
*-------------------------------------------------------------------------
*/
@ -5080,8 +5080,16 @@ dumpCast(Archive *fout, CastInfo *cast)
if (!OidIsValid(cast->castfunc))
appendPQExpBuffer(defqry, "WITHOUT FUNCTION");
else
appendPQExpBuffer(defqry, "WITH FUNCTION %s",
{
/*
* Always qualify the function name, in case it is not in pg_catalog
* schema (format_function_signature won't qualify it).
*/
appendPQExpBuffer(defqry, "WITH FUNCTION %s.",
fmtId(funcInfo->pronamespace->nspname));
appendPQExpBuffer(defqry, "%s",
format_function_signature(funcInfo, NULL, true));
}
if (cast->castcontext == 'a')
appendPQExpBuffer(defqry, " AS ASSIGNMENT");