mirrors/postgres
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Treat exit code 128 (ERROR_WAIT_NO_CHILDREN) as non-fatal on Win32,

Browse Source 
since it can happen when a process fails to start when the system
is under high load.

Per several bug reports and many peoples investigation.

Back-patch to 8.4, which is as far back as the "deadman-switch"
for shared memory access exists.
This commit is contained in:
Magnus Hagander 2010-09-16 20:37:16 +00:00
parent e0664d5cdc
commit 0af6a873c5
1 changed files with 14 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
src/backend/postmaster/postmaster.c
View File

@ -37,7 +37,7 @@
* *
* *
* IDENTIFICATION * IDENTIFICATION
* $PostgreSQL: pgsql/src/backend/postmaster/postmaster.c,v 1.583.2.7 2009/12/02 17:41:07 tgl Exp $ * $PostgreSQL: pgsql/src/backend/postmaster/postmaster.c,v 1.583.2.8 2010/09/16 20:37:16 mha Exp $
* *
* NOTES * NOTES
* *
@ -2495,6 +2495,19 @@ CleanupBackend(int pid,
* assume everything is all right and proceed to remove the backend from * assume everything is all right and proceed to remove the backend from
* the active backend list. * the active backend list.
*/ */
#ifdef WIN32
/*
* On win32, also treat ERROR_WAIT_NO_CHILDREN (128) as nonfatal
* case, since that sometimes happens under load when the process fails
* to start properly (long before it starts using shared memory).
*/
if (exitstatus == ERROR_WAIT_NO_CHILDREN)
{
LogChildExit(LOG, _("server process"), pid, exitstatus);
exitstatus = 0;
}
#endif
if (!EXIT_STATUS_0(exitstatus) && !EXIT_STATUS_1(exitstatus)) if (!EXIT_STATUS_0(exitstatus) && !EXIT_STATUS_1(exitstatus))
{ {
HandleChildCrash(pid, exitstatus, _("server process")); HandleChildCrash(pid, exitstatus, _("server process"));