mirrors/postgres
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Disallow factorial of negative numbers

Browse Source 
The previous implementation returned 1 for all negative numbers, which
is not sensible under any definition.

Discussion: https://www.postgresql.org/message-id/flat/6ce1df0e-86a3-e544-743a-f357ff663f68%402ndquadrant.com
This commit is contained in:
Peter Eisentraut 2020-06-18 08:41:31 +02:00
parent 9d402c73ad
commit 0a40563ead
2 changed files with 6 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/backend/utils/adt/numeric.c
View File

@ -2946,6 +2946,10 @@ numeric_fac(PG_FUNCTION_ARGS)
NumericVar fact; NumericVar fact;
NumericVar result; NumericVar result;
if (num < 0)
ereport(ERROR,
(errcode(ERRCODE_NUMERIC_VALUE_OUT_OF_RANGE),
errmsg("factorial of a negative number is undefined")));
if (num <= 1) if (num <= 1)
{ {
res = make_result(&const_one); res = make_result(&const_one);

12
src/test/regress/expected/numeric.out
View File

@ -2345,14 +2345,6 @@ SELECT 0!;
(1 row) (1 row)
SELECT -4!; SELECT -4!;
?column? ERROR: factorial of a negative number is undefined
----------
1
(1 row)
SELECT factorial(-4); SELECT factorial(-4);
factorial ERROR: factorial of a negative number is undefined
-----------
1
(1 row)