mirrors/postgres
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Always initialize PartitionBoundInfoData's null_index.

Browse Source 
This doesn't actually matter at present, because the current code
never consults null_index for range partitions.  However, leaving
it uninitialized is still a bad idea, so let's not do that.

Amul Sul, reviewed by Ashutosh Bapat

Discussion: http://postgr.es/m/CAAJ_b94AkEzcx+12ySCnbMDX7=UdF4BjnoBGfMQbB0RNSTo3Ng@mail.gmail.com
This commit is contained in:
Robert Haas 2017-06-13 12:36:45 -04:00
parent b6263cd851
commit 096f1ccd52
1 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/backend/catalog/partition.c
View File

@ -454,6 +454,7 @@ RelationBuildPartitionDesc(Relation rel)
palloc0(sizeof(PartitionBoundInfoData));
boundinfo->strategy = key->strategy;
boundinfo->ndatums = ndatums;
boundinfo->null_index = -1;
boundinfo->datums = (Datum **) palloc0(ndatums * sizeof(Datum *));
/* Initialize mapping array with invalid values */
@ -503,8 +504,6 @@ RelationBuildPartitionDesc(Relation rel)
mapping[null_index] = next_index++;
boundinfo->null_index = mapping[null_index];
}
else
boundinfo->null_index = -1;
/* All partition must now have a valid mapping */
Assert(next_index == nparts);