diff --git a/doc/src/sgml/logical-replication.sgml b/doc/src/sgml/logical-replication.sgml
index ccdd24312b..a23a3d57e2 100644
--- a/doc/src/sgml/logical-replication.sgml
+++ b/doc/src/sgml/logical-replication.sgml
@@ -725,32 +725,45 @@ ALTER SUBSCRIPTION
- On the subscriber node, use the following SQL to identify which slots
- should be synced to the standby that we plan to promote. This query will
- return the relevant replication slots, including the main slots and table
- synchronization slots associated with the failover-enabled subscriptions.
- Note that the table sync slot should be synced to the standby server only
- if the table copy is finished (See ).
+ On the subscriber node, use the following SQL to identify which replication
+ slots should be synced to the standby that we plan to promote. This query
+ will return the relevant replication slots associated with the
+ failover-enabled subscriptions.
+
+test_sub=# SELECT
+ array_agg(quote_literal(s.subslotname)) AS slots
+ FROM pg_subscription s
+ WHERE s.subfailover AND
+ s.subslotname IS NOT NULL;
+ slots
+-------
+ {'sub1','sub2','sub3'}
+(1 row)
+
+
+
+
+ On the subscriber node, use the following SQL to identify which table
+ synchronization slots should be synced to the standby that we plan to promote.
+ This query needs to be run on each database that includes the failover-enabled
+ subscription(s). Note that the table sync slot should be synced to the standby
+ server only if the table copy is finished
+ (See ).
We don't need to ensure that the table sync slots are synced in other scenarios
as they will either be dropped or re-created on the new primary server in those
cases.
test_sub=# SELECT
- array_agg(slot_name) AS slots
+ array_agg(quote_literal(slot_name)) AS slots
FROM
- ((
- SELECT r.srsubid AS subid, CONCAT('pg_', srsubid, '_sync_', srrelid, '_', ctl.system_identifier) AS slot_name
+ (
+ SELECT CONCAT('pg_', srsubid, '_sync_', srrelid, '_', ctl.system_identifier) AS slot_name
FROM pg_control_system() ctl, pg_subscription_rel r, pg_subscription s
WHERE r.srsubstate = 'f' AND s.oid = r.srsubid AND s.subfailover
- ) UNION (
- SELECT s.oid AS subid, s.subslotname as slot_name
- FROM pg_subscription s
- WHERE s.subfailover
- ))
- WHERE slot_name IS NOT NULL;
+ );
slots
-------
- {sub1,sub2,sub3}
+ {'pg_16394_sync_16385_7394666715149055164'}
(1 row)
@@ -761,13 +774,15 @@ test_sub=# SELECT
test_standby=# SELECT slot_name, (synced AND NOT temporary AND NOT conflicting) AS failover_ready
FROM pg_replication_slots
- WHERE slot_name IN ('sub1','sub2','sub3');
- slot_name | failover_ready
--------------+----------------
- sub1 | t
- sub2 | t
- sub3 | t
-(3 rows)
+ WHERE slot_name IN
+ ('sub1','sub2','sub3', 'pg_16394_sync_16385_7394666715149055164');
+ slot_name | failover_ready
+--------------------------------------------+----------------
+ sub1 | t
+ sub2 | t
+ sub3 | t
+ pg_16394_sync_16385_7394666715149055164 | t
+(4 rows)
diff --git a/doc/src/sgml/ref/alter_subscription.sgml b/doc/src/sgml/ref/alter_subscription.sgml
index 6af6d0d2c8..fdc648d007 100644
--- a/doc/src/sgml/ref/alter_subscription.sgml
+++ b/doc/src/sgml/ref/alter_subscription.sgml
@@ -72,8 +72,13 @@ ALTER SUBSCRIPTION name RENAME TO <
ALTER SUBSCRIPTION ... SET (failover = true|false) and
ALTER SUBSCRIPTION ... SET (two_phase = false)
cannot be executed inside a transaction block.
+
- These commands also cannot be executed when the subscription has
+
+ Commands ALTER SUBSCRIPTION ... REFRESH PUBLICATION and
+ ALTER SUBSCRIPTION ... {SET|ADD|DROP} PUBLICATION ...
+ with refresh option as true also cannot
+ be executed when the subscription has
two_phase
commit enabled, unless
copy_data