mirrors/postgres
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix instable 006_login_trigger.pl test

Browse Source 
Handling of login trigger FATAL error could cause a timing-dependant panic of
IPC::Run.  This commit excludes checks which involves handling of such errors.

Reported-by: Tom Lane
Discussion: https://postgr.es/m/2268825.1698618066%40sss.pgh.pa.us
This commit is contained in:
Alexander Korotkov 2023-10-30 01:23:53 +03:00
parent 5ba4cc3090
commit 06be01eb26
1 changed files with 3 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
src/test/authentication/t/006_login_trigger.pl
View File

@ -143,27 +143,16 @@ psql_command(
log_exact => '2', log_exact => '2',
err_like => [qr/You are welcome/]); err_like => [qr/You are welcome/]);
# Try to log as allowed Alice and disallowed Mallory (two times) # Try to login as allowed Alice. We don't check the Mallroy login, because
# FATAL error could cause a timing-dependant panic of IPC::Run.
psql_command( psql_command(
$node, 'SELECT 1;', 0, 'try regress_alice', $node, 'SELECT 1;', 0, 'try regress_alice',
connstr => 'user=regress_alice', connstr => 'user=regress_alice',
log_exact => '1', log_exact => '1',
err_like => [qr/You are welcome/], err_like => [qr/You are welcome/],
err_unlike => [qr/You are NOT welcome/]); err_unlike => [qr/You are NOT welcome/]);
psql_command(
$node, 'SELECT 1;', 2, 'try regress_mallory',
connstr => 'user=regress_mallory',
log_exact => '',
err_like => [qr/You are NOT welcome/],
err_unlike => [qr/You are welcome/]);
psql_command(
$node, 'SELECT 1;', 2, 'try regress_mallory',
connstr => 'user=regress_mallory',
log_exact => '',
err_like => [qr/You are NOT welcome/],
err_unlike => [qr/You are welcome/]);
# Check that Alice's login record is here, while the Mallory's one is not # Check that Alice's login record is here
psql_command( psql_command(
$node, 'SELECT * FROM user_logins;', 0, 'select *', $node, 'SELECT * FROM user_logins;', 0, 'select *',
log_like => [qr/3\|regress_alice/], log_like => [qr/3\|regress_alice/],